Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pre-commit to gitlab #31905

Merged
merged 125 commits into from Mar 25, 2024
Merged

add pre-commit to gitlab #31905

merged 125 commits into from Mar 25, 2024

Conversation

ilaner
Copy link
Contributor

@ilaner ilaner commented Jan 2, 2024

Adds pre-commit to gitlab ci, including content and sdk nightly.

fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-9486?filter=-1
fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-9591?filter=-1
fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-7058?filter=-1
fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-9475?filter=-1

content nightly: https://gitlab.xdr.pan.local/xdr/cortex-content/content/-/pipelines/910881
content nightly passed, only abnormal modeling rules failed and it fails in the regular nightly as well

Copy link

guardrails bot commented Jan 7, 2024

All previously detected findings have been fixed. Good job! 👍🎉

We will keep this comment up-to-date as you go along and notify you of any security issues that we identify.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

Copy link

github-actions bot commented Jan 7, 2024

Your contributed PolySwarm pack has been modified on files:

Packs/PolySwarm/Integrations/PolySwarmV2/PolySwarmV2_test.py
Please review the changes here

Copy link

github-actions bot commented Jan 7, 2024

Your contributed CofenseTriage pack has been modified on files:

Packs/CofenseTriage/Integrations/CofenseTriagev2/CofenseTriagev2_test.py
Packs/CofenseTriage/Integrations/CofenseTriagev2/CofenseTriagev2.py
Please review the changes here

Copy link

github-actions bot commented Jan 7, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/CheckpointFirewall/Integrations/CheckPointFirewallV2
   CheckPointFirewallV2.py79722971%53–54, 87, 101, 106, 118, 126, 128, 131, 136, 140, 144, 150–151, 158, 160, 163, 167, 172, 177, 185, 191, 200, 204, 208, 213, 217, 223, 228, 232, 236, 239, 244, 246, 251, 260, 264, 269–270, 274, 276, 284, 293, 297–298, 301–302, 305, 309, 314, 316, 320, 322, 326, 330–331, 335, 338, 341, 345, 349, 352, 356, 361, 365–366, 370, 374–375, 377–379, 383, 387, 391, 395, 415, 487, 694, 822, 865, 1324, 1327–1328, 1331–1332, 1335, 1396–1397, 1399–1400, 1402–1407, 1409, 1412, 1419, 1431–1433, 1437, 1444, 1457–1458, 1460, 1462–1467, 1469–1470, 1473–1474, 1477, 1484, 1504–1505, 1507–1515, 1517, 1524, 1536–1546, 1548, 1555, 1566–1570, 1572–1580, 1583, 1585, 1592, 1604–1614, 1616, 1623, 1700–1701, 1715–1716, 1718–1719, 1721, 1723–1725, 1727, 1734, 1761–1763, 1765–1767, 1769, 1776, 1874, 1906–1907, 1909–1912, 1915, 1922, 1933–1934, 1936–1939, 1941, 1948, 1957–1958, 1962–1965, 1967–1969, 1974–1976, 1981, 2037–2038, 2040
Packs/CofenseTriage/Integrations/CofenseTriagev2
   CofenseTriagev2.py3587579%51–53, 56, 93, 105–107, 172, 331, 339, 376, 392, 429, 447–449, 454–456, 531, 543–545, 549–551, 568–569, 604, 616, 653, 656, 720–721, 723, 725–728, 730–731, 734, 738–740, 742, 744, 746, 749, 762, 787–788, 790, 792–793, 795–796, 798–799, 801–802, 804–805, 807–808, 810–811, 813–814, 816–817, 819–821
Packs/McAfeeNSM/Integrations/McAfeeNSMv2
   McAfeeNSMv2.py93623275%57–59, 68–69, 78–79, 120–121, 130–131, 179–196, 206–207, 210, 220–221, 223–225, 235–238, 248–252, 261–262, 271–272, 297, 299, 310–311, 321–323, 332–333, 343–344, 357–358, 360, 421–422, 439, 444–445, 456–457, 531–535, 537, 545–547, 549, 658, 820, 867, 986–991, 995–997, 1012, 1085, 1103–1107, 1123, 1289, 1297, 1362, 1367, 1372, 1412, 1458, 1484, 1533, 1537, 1541, 1545, 1549, 1553, 1565, 1571, 1576, 1578, 1581, 1584, 1589, 1594–1597, 1603–1606, 1610–1623, 1642, 1687, 1690, 1692, 1694, 1696, 1699, 1750, 1776–1779, 1803–1807, 1818–1819, 1825, 1846, 1851–1852, 1886, 1888, 1913, 1930–1932, 1962, 2004, 2035, 2084–2087, 2103, 2114, 2116, 2122, 2156, 2165–2167, 2178–2183, 2185–2189, 2192–2193, 2198, 2214–2216, 2219–2221, 2298–2303, 2305, 2309–2310, 2358–2366, 2369–2370, 2372, 2379–2380, 2482
Packs/PolySwarm/Integrations/PolySwarmV2
   PolySwarmV2.py1915869%17–18, 58, 60–66, 68, 76, 95, 98, 144–145, 163–164, 172–173, 198–199, 219–220, 247–248, 258, 268–269, 321–323, 325–326, 328–330, 332–350, 352–353
Packs/SecureWorks/Integrations/TaegisXDRv2
   TaegisXDRv2.py4663392%122, 130–131, 830, 1009, 1706–1707, 1722–1723, 1725, 1750–1754, 1756–1758, 1760, 1762, 1770, 1772–1774, 1776–1777, 1786–1789, 1791–1793
Packs/ServiceNow/Integrations/ServiceNow_CMDB
   ServiceNow_CMDB.py2699963%110–111, 118–119, 164–166, 207, 209, 211, 245, 247–250, 252, 254, 269, 273, 293, 295–298, 300, 302, 314, 335, 337–340, 342, 344, 355, 376, 378–381, 383, 385, 396, 418, 420–423, 425, 427, 436, 455–456, 459–463, 470–471, 474–479, 493–494, 498–502, 504–505, 508, 517, 519–524, 526–528, 530, 533, 544, 546–548, 550–553, 555, 558–559
Packs/ServiceNow/Integrations/ServiceNow_IAM
   ServiceNow_IAM.py1768054%25–26, 42, 45–46, 51, 54–55, 60, 63–65, 70–75, 77, 96–97, 99–100, 128–129, 177, 191–192, 194–197, 207–208, 218, 245–246, 289–290, 294–295, 301–314, 316–320, 322, 327, 336, 338–339, 341–342, 345–346, 349–350, 352–353, 355–357, 359–360, 362, 364
Packs/Slack/Integrations/Slack_IAM
   Slack_IAM.py28624315%23–25, 28–29, 32, 37–42, 44–45, 48–54, 59–63, 65, 68–72, 74, 79–83, 85, 88–89, 92–93, 96–98, 103–108, 110, 121–127, 129–130, 132, 137, 147, 150–153, 162, 165–166, 172–173, 176, 183–184, 191–192, 199–200, 206–209, 211, 213–216, 218–219, 221, 223, 225, 232–233, 258–271, 286, 294, 296–298, 302, 304–305, 307–311, 313–315, 317, 325, 327, 330, 337–338, 340–344, 347–348, 351, 355, 365–367, 369–372, 374, 376–379, 382–383, 386, 396–397, 399–400, 402–404, 406–407, 410–411, 415, 425, 427–428, 430–433, 435–436, 438–443, 448–452, 459, 461, 463–466, 469–470, 473, 483–486, 488–490, 492–498, 500, 504–505, 511, 519, 526, 528–529, 531–532, 534–535, 537–538, 540, 542, 544–546, 548–549, 551, 553, 555–556, 558–559, 561–562, 564–565
Packs/Tanium/Integrations/Tanium_v2
   Tanium_v2.py70147432%36–37, 40–45, 48–49, 51, 54, 72, 77, 86, 93–94, 96–98, 100–103, 107, 109, 154–157, 159, 183, 194–195, 203, 208, 210, 222, 232–236, 247, 249, 254, 270, 273, 281, 285, 288, 296, 303–304, 323, 341–344, 346–350, 352–356, 362–363, 366, 375–377, 379–383, 386, 403–407, 409–413, 434–435, 439–441, 451–452, 464, 483–487, 489–492, 494, 497, 518–522, 524, 527, 535, 546, 552, 554–555, 557, 559, 566–568, 572–573, 575–578, 580–583, 587–595, 597–600, 602–603, 605–606, 608–611, 615–617, 619–620, 622–623, 625–626, 628–631, 635–637, 640–641, 643–645, 647–650, 654–662, 664–665, 667–668, 670–671, 673–675, 679–680, 682, 684–687, 689–692, 696–697, 699–701, 703–704, 706–709, 713–716, 718–721, 730, 732, 734–736, 739–743, 747–750, 752–753, 755–758, 762–770, 772–773, 775–778, 782–785, 787, 789–792, 795–799, 803–804, 806, 808–810, 812–815, 819–826, 828, 833–834, 836–839, 843–851, 853, 858–859, 861–864, 868–871, 873–876, 880–881, 883, 885–887, 889–892, 896–898, 900–902, 904–907, 911–919, 921–922, 924–927, 931–932, 934, 936–938, 940–943, 947–948, 950–953, 955–958, 962–964, 966–967, 969, 971–972, 974–977, 979–982, 984–985, 987–989, 991–994, 998–999, 1001, 1003–1005, 1007–1010, 1014–1022, 1024–1026, 1028–1031, 1035–1036, 1038, 1040–1041, 1043–1046, 1050–1056, 1082–1083, 1097–1100, 1102, 1104, 1106–1107, 1110–1113, 1115, 1146–1149, 1151–1153, 1157
Packs/ThreatExchange/Integrations/ThreatExchangeV2
   ThreatExchangeV2.py38028624%47–48, 62, 75, 90, 102, 119, 133, 150, 164, 174, 180, 201, 217, 231, 242, 258–259, 271, 281, 288, 319, 322, 326, 408–411, 414, 416, 430, 437–438, 457–458, 465–471, 473–478, 480–487, 495–496, 498–499, 507, 514–515, 520, 528, 530, 537–543, 545–550, 552–558, 566–567, 570–572, 584, 591–592, 596, 604, 606, 613–621, 623–626, 628–632, 637–643, 651–652, 654–655, 662, 669–670, 675, 683, 685, 692–704, 706–710, 715–721, 729–730, 732–733, 740, 747–748, 753, 761, 763, 774–777, 779, 781, 788, 795–803, 805–809, 811–815, 817, 820–821, 823–824, 826, 834, 844–846, 848–852, 854–858, 860, 863–864, 866, 868, 875, 884–888, 890–894, 896–897, 899–901, 903, 906–907, 909, 911, 918, 925, 927–929, 931, 933, 940, 947–949, 951–958, 960–962, 969–988, 990–991, 993–995
TOTAL4560180960% 

Tests Skipped Failures Errors Time
17 0 💤 0 ❌ 0 🔥 1.984s ⏱️

.gitlab/ci/.gitlab-ci.global.yml Show resolved Hide resolved
.gitlab/ci/.gitlab-ci.on-push.yml Show resolved Hide resolved
policy: pull-push

rules:
- if: '$BUCKET_UPLOAD == "true"'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

open an issue for the bucket pre-commit please

.gitlab/ci/.gitlab-ci.on-push.yml Show resolved Hide resolved
.pre-commit-config_template.yaml Show resolved Hide resolved
@@ -53,6 +53,13 @@ def test_boo(capfd):
pytest.fail("Found output in stderr: [{}]".format(err.strip()))


def pytest_sessionfinish(session, exitstatus):
"""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

document please

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

documented

pyproject.toml Outdated Show resolved Hide resolved
@ilaner ilaner requested a review from dorschw March 20, 2024 09:28
@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • ServiceNow pack version was bumped to 2.5.62.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • Slack pack version was bumped to 3.4.10.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@yuvalbenshalom yuvalbenshalom merged commit 11c7952 into master Mar 25, 2024
13 of 17 checks passed
@yuvalbenshalom yuvalbenshalom deleted the pre-commit-all branch March 25, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants