Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated outputs to cmds ip and abuseipdb-check-cidr-block #31946

Merged
merged 6 commits into from Jan 8, 2024
Merged

Updated outputs to cmds ip and abuseipdb-check-cidr-block #31946

merged 6 commits into from Jan 8, 2024

Conversation

chloerongier
Copy link
Contributor

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

Not all the IP analysis's fields were returned, so this PR will add all of them in new context outputs.
New outputs added:
- IP.Geo.CountryName
- IP.Geo.CountryCode
- AbuseIPDB.IP.Geo.CountryName
- AbuseIPDB.IP.Geo.CountryCode
- AbuseIPDB.IP.Hostnames
- AbuseIPDB.IP.IpVersion
- AbuseIPDB.IP.IsPublic
- AbuseIPDB.IP.IsTor
- AbuseIPDB.IP.IsWhitelisted
- AbuseIPDB.IP.LastReportedAt
- AbuseIPDB.IP.NumDistinctUsers

Must have

  • Tests
  • Documentation

@content-bot content-bot added Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! External PR Xsoar Support Level Indicates that the contribution is for XSOAR supported pack labels Jan 3, 2024
@content-bot content-bot changed the base branch from master to contrib/chloerongier_master-1 January 3, 2024 16:35
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @yucohen will know the proposed changes are ready to be reviewed.
For your convenience, here is a link to the contributions SLAs document.

@content-bot
Copy link
Collaborator

Hi @chloerongier, thanks for contributing to a Cortex XSOAR supported pack. To receive credit for your generous contribution please follow this link.

yucohen
yucohen requested changes Jan 7, 2024
View reviewed changes
Copy link
Contributor

@yucohen yucohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @chloerongier
Thanks for your contribution! We highly appreciate it.
Great work!
Please see my comments

Packs/AbuseDB/Integrations/AbuseDB/AbuseDB.yml Outdated
Comment on lines 116 to 117
- contextPath: IP.Geo.Country
description: The country in which the IP address is located.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing an output can be a breaking backward compatibility change.
Lets leave it as is, and also add the other data you added

@yucohen yucohen added the pending-contributor The PR is pending the response of its creator label Jan 7, 2024
@yucohen yucohen added ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. and removed pending-contributor The PR is pending the response of its creator labels Jan 8, 2024
@content-bot
Copy link
Collaborator

content-bot commented Jan 8, 2024 •
edited

For the Reviewer: Successfully created a pipeline in Gitlab with url: https://gitlab.xdr.pan.local/xdr/cortex-content/content/-/pipelines/748070

@yucohen yucohen added ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. and removed ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. labels Jan 8, 2024
@yucohen yucohen merged commit 5618dcd into demisto:contrib/chloerongier_master-1 Jan 8, 2024
14 of 21 checks passed
@yucohen
Copy link
Contributor

yucohen commented Jan 8, 2024

@chloerongier Thanks again for your contribution! Your PR was merged and your changes will be available in the marketplace in the next 72 hours.

@content-bot content-bot mentioned this pull request Jan 8, 2024
Merged
5 tasks
yucohen added a commit that referenced this pull request Jan 9, 2024
@content-bot @chloerongier @yucohen
Updated outputs to cmds ip and abuseipdb-check-cidr-block (#31946) (#…
9cdb3be 
…32040)

* Updated outputs to cmds ip and abuseipdb-check-cidr-block

* Updated outputs to cmds ip and abuseipdb-check-cidr-block

* remove comma

* fix: return to previous arg name

* Update Packs/AbuseDB/ReleaseNotes/1_0_30.md

---------

Co-authored-by: chloerongier <150173582+chloerongier@users.noreply.github.com>
Co-authored-by: Yuval Cohen <86777474+yucohen@users.noreply.github.com>
dantavori pushed a commit that referenced this pull request Jan 14, 2024
@content-bot @chloerongier
@yucohen @dantavori
Updated outputs to cmds ip and abuseipdb-check-cidr-block (#31946) (#…
680173e 
…32040)

* Updated outputs to cmds ip and abuseipdb-check-cidr-block

* Updated outputs to cmds ip and abuseipdb-check-cidr-block

* remove comma

* fix: return to previous arg name

* Update Packs/AbuseDB/ReleaseNotes/1_0_30.md

---------

Co-authored-by: chloerongier <150173582+chloerongier@users.noreply.github.com>
Co-authored-by: Yuval Cohen <86777474+yucohen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yucohen yucohen yucohen approved these changes

@MLainer1 MLainer1 Awaiting requested review from MLainer1

Assignees

@yucohen yucohen

Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! External PR ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. TIM Review Xsoar Support Level Indicates that the contribution is for XSOAR supported pack
Projects
None yet
Milestone
No milestone
3 participants
@chloerongier @content-bot @yucohen