Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated outputs to cmds ip and abuseipdb-check-cidr-block #32040

Merged
merged 3 commits into from Jan 9, 2024

Conversation

content-bot
Copy link
Collaborator

@content-bot content-bot commented Jan 8, 2024

Original External PR

external pull request

Contributor

@chloerongier

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

Not all the IP analysis's fields were returned, so this PR will add all of them in new context outputs.
New outputs added:
- IP.Geo.CountryCode
- AbuseIPDB.IP.Geo.CountryName
- AbuseIPDB.IP.Geo.CountryCode
- AbuseIPDB.IP.Hostnames
- AbuseIPDB.IP.IpVersion
- AbuseIPDB.IP.IsPublic
- AbuseIPDB.IP.IsTor
- AbuseIPDB.IP.IsWhitelisted
- AbuseIPDB.IP.LastReportedAt
- AbuseIPDB.IP.NumDistinctUsers

Must have

  • Tests
  • Documentation

* Updated outputs to cmds ip and abuseipdb-check-cidr-block

* Updated outputs to cmds ip and abuseipdb-check-cidr-block

* remove comma

* fix: return to previous arg name

* Update Packs/AbuseDB/ReleaseNotes/1_0_30.md

---------

Co-authored-by: Yuval Cohen <86777474+yucohen@users.noreply.github.com>
@content-bot content-bot added Contribution Thank you! Contributions are always welcome! ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. Contribution Form Filled Whether contribution form filled or not. Community Xsoar Support Level Indicates that the contribution is for XSOAR supported pack Internal PR TIM Review labels Jan 8, 2024
Copy link

github-actions bot commented Jan 8, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/AbuseDB/Integrations/AbuseDB
   AbuseDB.py1598447%43–46, 109, 114, 116–119, 123, 135, 139–140, 142–144, 151, 173–176, 178, 180–182, 188, 196–197, 199–201, 207, 211–212, 214–221, 230, 234–237, 241, 254, 273, 284–285, 290–291, 293, 298, 302–303, 308, 312–313, 317, 322–323, 327–332, 336–337, 346, 355, 359, 361, 363, 365, 367, 369, 371–373
TOTAL1598447% 

Tests Skipped Failures Errors Time
1 0 💤 0 ❌ 0 🔥 1.736s ⏱️

@yucohen yucohen merged commit 9cdb3be into master Jan 9, 2024
16 of 17 checks passed
@yucohen yucohen deleted the contrib/chloerongier_master-1 branch January 9, 2024 18:58
dantavori pushed a commit that referenced this pull request Jan 14, 2024
…32040)

* Updated outputs to cmds ip and abuseipdb-check-cidr-block

* Updated outputs to cmds ip and abuseipdb-check-cidr-block

* remove comma

* fix: return to previous arg name

* Update Packs/AbuseDB/ReleaseNotes/1_0_30.md

---------

Co-authored-by: chloerongier <150173582+chloerongier@users.noreply.github.com>
Co-authored-by: Yuval Cohen <86777474+yucohen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved Internal PR ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. TIM Review Xsoar Support Level Indicates that the contribution is for XSOAR supported pack
Projects
None yet
3 participants