EXPANDR-5776 - AWS Hierarchy Information #31951

johnnywilkes · 2024-01-03T19:41:06Z

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

In Progress
Ready
In Hold - (Reason for hold)

Related Issues

https://jira-dc.paloaltonetworks.com/browse/EXPANDR-5776

Description

Finding the hierarchy structure of an AWS Account (such as Account->OU->Root) is important to determine if the account is associated with Dev/PROD/other. With the new AWS - Organizations Pack/integration we can now look up this information with a new automation (AWSAccountHierarchy) and add this to our playbook.

Must have

Tests
Documentation

content-bot · 2024-01-03T19:42:56Z

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @YuvHayun will know the proposed changes are ready to be reviewed.
For your convenience, here is a link to the contributions SLAs document.

content-bot · 2024-01-03T19:42:57Z

Hi @johnnywilkes, thanks for contributing to a Cortex XSOAR supported pack. To receive credit for your generous contribution please follow this link.

johnnywilkes · 2024-01-03T19:45:32Z

@ShirleyDenkberg , can you please review?

johnnywilkes · 2024-01-03T19:46:02Z

@melamedbn / @YuvHayun On hold until #31849 is merged

Packs/AWS-Enrichment-Remediation/Playbooks/AWS_-_Enrichment.yml

Packs/AWS-Enrichment-Remediation/Scripts/AWSAccountHierarchy/AWSAccountHierarchy.yml

Packs/AWS-Enrichment-Remediation/Playbooks/AWS_-_Enrichment.yml

Packs/AWS-Enrichment-Remediation/README.md

Packs/AWS-Enrichment-Remediation/ReleaseNotes/1_1_12.md

Packs/AWS-Enrichment-Remediation/Scripts/AWSAccountHierarchy/README.md

ShirleyDenkberg · 2024-01-04T06:28:02Z

@melamedbn @YuvHayun Doc review completed.

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

YuvHayun

Hi @johnnywilkes, looks great!
Please see my comments.
Also, please get the PR out of draft mode if it's ready.

Packs/AWS-Organizations/pack_metadata.json

Packs/AWS-Organizations/Integrations/AWSOrganizations/AWSOrganizations.yml

Packs/AWS-Enrichment-Remediation/pack_metadata.json

Packs/AWS-Enrichment-Remediation/Scripts/AWSAccountHierarchy/AWSAccountHierarchy.py

johnnywilkes · 2024-01-08T10:26:56Z

@YuvHayun , on hold until #31958 is merged

YuvHayun

Looks good, let me know when the other PR is merged and I can trigger tests on this one.

johnnywilkes · 2024-01-10T12:06:31Z

@melamedbn / @YuvHayun , this is ready to merge, please and thank you

…-E+R-EXPANDR-5776

YuvHayun · 2024-01-10T13:35:52Z

@johnnywilkes please pull from master and notice the pre-commit failures with the dockers.

content-bot · 2024-01-10T13:36:23Z

For the Reviewer: Successfully created a pipeline in Gitlab with url: https://gitlab.xdr.pan.local/xdr/cortex-content/content/-/pipelines/754326

Packs/AWS-Organizations/ReleaseNotes/1_0_1.md

Co-authored-by: Yuval Hayun <70104171+YuvHayun@users.noreply.github.com>

…-E+R-EXPANDR-5776

YuvHayun · 2024-01-11T07:37:46Z

merging to internal pr.

* EXPANDR-5776 - AWS Hierarchy Information (#31951) * init * more unit tests * updates * add play * RN * update pack README link * Apply suggestions from code review Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * update int check * update coverage * fix validation errors * AWS org RN * AWS E+R ver bump * bump docker * fix val errors * Update Packs/AWS-Organizations/ReleaseNotes/1_0_1.md Co-authored-by: Yuval Hayun <70104171+YuvHayun@users.noreply.github.com> * change per Yuval --------- Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> Co-authored-by: Yuval Hayun <70104171+YuvHayun@users.noreply.github.com> * Update Packs/AWS-Enrichment-Remediation/ReleaseNotes/1_1_13.md * Update Packs/AWS-Organizations/ReleaseNotes/1_0_1.md * Bump pack from version AWS-Enrichment-Remediation to 1.1.14. * add from versino * revert * compare to master --------- Co-authored-by: johnnywilkes <32227961+johnnywilkes@users.noreply.github.com> Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> Co-authored-by: Yuval Hayun <70104171+YuvHayun@users.noreply.github.com> Co-authored-by: YuvHayun <yhayun@paloaltonetworks.com> Co-authored-by: Content Bot <bot@demisto.com> Co-authored-by: MosheEichler <meichler@paloaltonetworks.com> Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com>

johnnywilkes and others added 6 commits January 2, 2024 17:38

init

e06ea80

more unit tests

5c22197

updates

c025e1a

add play

7d0f1d1

RN

a3fe2d3

Merge branch 'master' into ASM-E+R-EXPANDR-5776

2651e6e

content-bot added Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! External PR Xsoar Support Level Indicates that the contribution is for XSOAR supported pack labels Jan 3, 2024

content-bot changed the base branch from master to contrib/PaloAltoNetworks_ASM-E+R-EXPANDR-5776 January 3, 2024 19:42

content-bot assigned YuvHayun and melamedbn Jan 3, 2024

content-bot added the Security Review label Jan 3, 2024

content-bot requested review from melamedbn and YuvHayun January 3, 2024 19:42

update pack README link

84ea672

johnnywilkes marked this pull request as draft January 3, 2024 19:45

ShirleyDenkberg self-assigned this Jan 4, 2024

ShirleyDenkberg reviewed Jan 4, 2024

View reviewed changes

ShirleyDenkberg added the docs-approved label Jan 4, 2024

YuvHayun added the pending-contributor The PR is pending the response of its creator label Jan 4, 2024

johnnywilkes and others added 2 commits January 4, 2024 16:25

Apply suggestions from code review

3f343e3

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

update int check

b1fdb34

johnnywilkes mentioned this pull request Jan 6, 2024

[ASM] EXPANDR-5776: Add AWS Hierarchy Info to Main Playbook #31991

Merged

5 tasks

YuvHayun requested changes Jan 7, 2024

View reviewed changes

johnnywilkes marked this pull request as ready for review January 8, 2024 10:20

johnnywilkes marked this pull request as draft January 8, 2024 10:25

johnnywilkes added 2 commits January 8, 2024 05:38

AWS org RN

5e52279

AWS E+R ver bump

9f64c8e

YuvHayun approved these changes Jan 8, 2024

View reviewed changes

melamedbn approved these changes Jan 9, 2024

View reviewed changes

johnnywilkes marked this pull request as ready for review January 10, 2024 12:01

Merge branch 'master' into ASM-E+R-EXPANDR-5776

b3d9909

johnnywilkes force-pushed the ASM-E+R-EXPANDR-5776 branch from bca95c1 to b3d9909 Compare January 10, 2024 12:13

johnnywilkes and others added 2 commits January 10, 2024 07:25

bump docker

9b643bf

Merge branch 'contrib/PaloAltoNetworks_ASM-E+R-EXPANDR-5776' into ASM…

9940ea0

…-E+R-EXPANDR-5776

YuvHayun added the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label Jan 10, 2024

fix val errors

43a3703

YuvHayun removed the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label Jan 10, 2024

YuvHayun reviewed Jan 10, 2024

View reviewed changes

Packs/AWS-Organizations/ReleaseNotes/1_0_1.md Outdated Show resolved Hide resolved

YuvHayun approved these changes Jan 10, 2024

View reviewed changes

johnnywilkes and others added 3 commits January 10, 2024 09:04

Update Packs/AWS-Organizations/ReleaseNotes/1_0_1.md

5c8cf70

Co-authored-by: Yuval Hayun <70104171+YuvHayun@users.noreply.github.com>

change per Yuval

2d9b723

Merge branch 'contrib/PaloAltoNetworks_ASM-E+R-EXPANDR-5776' into ASM…

16bad12

…-E+R-EXPANDR-5776

YuvHayun merged commit a76e6a8 into demisto:contrib/PaloAltoNetworks_ASM-E+R-EXPANDR-5776 Jan 11, 2024
20 of 21 checks passed

content-bot mentioned this pull request Jan 11, 2024

EXPANDR-5776 - AWS Hierarchy Information #32123

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

EXPANDR-5776 - AWS Hierarchy Information #31951

EXPANDR-5776 - AWS Hierarchy Information #31951

johnnywilkes commented Jan 3, 2024

content-bot commented Jan 3, 2024

content-bot commented Jan 3, 2024

johnnywilkes commented Jan 3, 2024

johnnywilkes commented Jan 3, 2024

ShirleyDenkberg commented Jan 4, 2024

YuvHayun left a comment

johnnywilkes commented Jan 8, 2024

YuvHayun left a comment

johnnywilkes commented Jan 10, 2024

YuvHayun commented Jan 10, 2024

content-bot commented Jan 10, 2024

YuvHayun commented Jan 11, 2024

EXPANDR-5776 - AWS Hierarchy Information #31951

EXPANDR-5776 - AWS Hierarchy Information #31951

Conversation

johnnywilkes commented Jan 3, 2024

Contributing to Cortex XSOAR Content

Status

Related Issues

Description

Must have

content-bot commented Jan 3, 2024

content-bot commented Jan 3, 2024

johnnywilkes commented Jan 3, 2024

johnnywilkes commented Jan 3, 2024

ShirleyDenkberg commented Jan 4, 2024

YuvHayun left a comment

Choose a reason for hiding this comment

johnnywilkes commented Jan 8, 2024

YuvHayun left a comment

Choose a reason for hiding this comment

johnnywilkes commented Jan 10, 2024

YuvHayun commented Jan 10, 2024

content-bot commented Jan 10, 2024

YuvHayun commented Jan 11, 2024