Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ASM] EXPANDR-5776: Add AWS Hierarchy Info to Main Playbook #31991

Merged
merged 5 commits into from Jan 14, 2024
Merged

[ASM] EXPANDR-5776: Add AWS Hierarchy Info to Main Playbook #31991

merged 5 commits into from Jan 14, 2024

Conversation

johnnywilkes
Copy link
Contributor

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

https://jira-dc.paloaltonetworks.com/browse/EXPANDR-5776

Description

Add AWS Hierarchy Info to Main Playbook

Must have

  • Tests
  • Documentation

@johnnywilkes johnnywilkes marked this pull request as draft January 6, 2024 11:19
@content-bot content-bot added Community Contribution Form Filled Whether contribution form filled or not. labels Jan 6, 2024
@johnnywilkes
Copy link
Contributor Author

@ShirleyDenkberg , can you please review?

@content-bot content-bot added Contribution Thank you! Contributions are always welcome! External PR Xsoar Support Level Indicates that the contribution is for XSOAR supported pack labels Jan 6, 2024
@content-bot content-bot changed the base branch from master to contrib/PaloAltoNetworks_ASM-EXPANDR-5776 January 6, 2024 11:20
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @YuvHayun will know the proposed changes are ready to be reviewed.
For your convenience, here is a link to the contributions SLAs document.

@content-bot
Copy link
Collaborator

Hi @johnnywilkes, thanks for contributing to a Cortex XSOAR supported pack. To receive credit for your generous contribution please follow this link.

@johnnywilkes
Copy link
Contributor Author

On hold until #31951 is complete

@YuvHayun YuvHayun added the pending-contributor The PR is pending the response of its creator label Jan 7, 2024
@melamedbn melamedbn removed their request for review January 7, 2024 08:49
@melamedbn melamedbn removed their assignment Jan 7, 2024
@johnnywilkes
Copy link
Contributor Author

@capanw / @BigEasyJ , please review this is on hold until #32123 is merged

@johnnywilkes johnnywilkes marked this pull request as ready for review January 12, 2024 18:04
@johnnywilkes
Copy link
Contributor Author

@ShirleyDenkberg , please review

@johnnywilkes
Copy link
Contributor Author

@YuvHayun , this has been approved by Xpanse team. Please merge when possible

@YuvHayun YuvHayun added the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label Jan 14, 2024
@content-bot
Copy link
Collaborator

content-bot commented Jan 14, 2024 •
edited

For the Reviewer: Successfully created a pipeline in Gitlab with url: https://gitlab.xdr.pan.local/xdr/cortex-content/content/-/pipelines/759889

@YuvHayun
Copy link
Contributor

Merging to internal pr.

@YuvHayun YuvHayun merged commit d72e820 into demisto:contrib/PaloAltoNetworks_ASM-EXPANDR-5776 Jan 14, 2024
26 of 27 checks passed
@content-bot content-bot mentioned this pull request Jan 14, 2024
Merged
5 tasks
YuvHayun added a commit that referenced this pull request Jan 14, 2024
@content-bot @johnnywilkes @YuvHayun
[ASM] EXPANDR-5776: Add AWS Hierarchy Info to Main Playbook (#31991) (#…
f67b2c3 
…32163)

* init

* RN

* update RN

* bumpty

Co-authored-by: johnnywilkes <32227961+johnnywilkes@users.noreply.github.com>
Co-authored-by: YuvHayun <yhayun@paloaltonetworks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuvHayun YuvHayun YuvHayun approved these changes

@capanw capanw capanw approved these changes

Assignees

@YuvHayun YuvHayun

Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved External PR pending-contributor The PR is pending the response of its creator ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. Security Review Xsoar Support Level Indicates that the contribution is for XSOAR supported pack
Projects
None yet
Milestone
No milestone
5 participants
@johnnywilkes @content-bot @YuvHayun @capanw @melamedbn