Trend micro vision one #32563
Trend micro vision one #32563
Conversation
…oming mapper, yml and README.md.
…ript. Updated test data and formatted YML.
content-bot
added
Contribution
content-bot
changed the base branch from
master
to
contrib/shaqnawe_TrendMicroVisionOne
|
@YuvHayun I have update the error description for delete and download custom script commands but I didn't add polling to run_custom_script command. Additionally the use case of passing multiple values has been requested by our clients so we have decided to keep the current convention of having the users enter a dictionary object. Please let me know if another demo is needed. As of not the PR is ready for merge. Thank you for your assistance! |
Packs/TrendMicroVisionOne/Integrations/TrendMicroVisionOneV3/TrendMicroVisionOneV3.yml
Show resolved
Hide resolved
| :rtype: ``dict` | ||
| """ | ||
| # Required Params | ||
| block_objects = safe_load_json(args[BLOCK_OBJECTS]) |
There was a problem hiding this comment.
Have you decided to skip the block builder?
There was a problem hiding this comment.
skipping the block builder to keep it uniform with other actions likes enable/disable account etc.
|
Also, a fix to the validate issue you have aws merge, please pull from master. |
|
@YuvHayun I have update the integration description to make it shorter. |
YuvHayun
added
the
ready-for-instance-test
|
For the Reviewer: Successfully created a pipeline in Gitlab with url: https://gitlab.xdr.pan.local/xdr/cortex-content/content/-/pipelines/858283 |
|
@YuvHayun can we please hold the merge. There's an update for pytmv1 package to address an API issue. I'm working on updating demisto-docker image and will update the dockerimage in yml ASAP. Thank you |
|
Created dockerfiles PR in relation to new pytmv1 package update. demisto/dockerfiles#24687 |
|
Updated |
|
Hey @shaqnawe, the docker pr was merged. |
|
Docker image has been updated to demisto/pytmv1:0.8.2.89444. |
|
@YuvHayun No more changes to make, ready for merge. |
|
Great job, thx a lot for your contribution, merging to internal pr. |
YuvHayun
merged commit 8d5dabe
into
demisto:contrib/shaqnawe_TrendMicroVisionOne
* updated integration and added 6 custom script actions and updated incoming mapper, yml and README.md. * added test data for custom script actions. * updated actions per pytmv1 0.8.0 * updated yml and README.md * fixed type in README.md description. * updated unit tests. * updated response attributes for download, update and delete custom script. Updated test data and formatted YML. * fixed mypy error in download_custom_script action. * updated reference for status in delete and update custom script actions. * updated link to support sandbox analysis file types. * updated docker image to updated pytmv1 package 0.8.0 * added dockerimage devdemisto/trend-pytmv1:0.8.0.86567 in yml. * Update Packs/TrendMicroVisionOne/Integrations/TrendMicroVisionOneV3/TrendMicroVisionOneV3.yml * Update Packs/TrendMicroVisionOne/Integrations/TrendMicroVisionOneV3/TrendMicroVisionOneV3.yml * Update Packs/TrendMicroVisionOne/Integrations/TrendMicroVisionOneV3/TrendMicroVisionOneV3.yml * added recommended changes. * updated README.md with cortex convention for action names. * updated dockerimage to demisto/pytmv1:0.8.0.87051 * added given-when-then docs for custom script actions and updated yml,README.md, and release notes. * reverted param name to endpoint in get_endpoint_info to avoid breaking changes. * added ip to secrets ignore. * fixed secrets format * updated add_note, update_status, get_endpoint and get_email activity data actions. * updated docker image to demisto/pytmv1:0.8.1.88013 * Update Packs/TrendMicroVisionOne/ReleaseNotes/4_1_0.md Updated release notes per YuvHayun's suggestion. * updated record.json() to model_dump_json in fetch_incidents per update in BaseModel class. * updated descriptions for required arguments for get-endpoint-info in README.md and yml * updated argument description for endpoint-info,endpoint and email-activity-data,endpoint and email-activity-data-count and get-custom-script * updated error description for download,delete custom script actions and added predefined value for query_op in get_custom_script_list. * added list options for filetype and shortened description. * added dropdown options for filetype in get custom script list as suggested. * updated dockerimage to pytmv1:0.8.2.89444 * updated release notes to reflect correct dockerimage number. --------- Co-authored-by: shaqnawe <shaktishah40@gmail.com> Co-authored-by: Yuval Hayun <70104171+YuvHayun@users.noreply.github.com>
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: link to the issue
Description
Updated incoming mapper attributes. Updated pytmv1 package to 0.8.0 to support 6 new custom script actions. Fixed an issue with endpoint and email activity data count actions, where query_op was not being parsed correctly. This integration will use the dockerfiles docker image here: updated pytmv1 to 0.8.0 #23882
Must have