Trend micro vision one #33238
Merged
Trend micro vision one #33238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* updated integration and added 6 custom script actions and updated incoming mapper, yml and README.md. * added test data for custom script actions. * updated actions per pytmv1 0.8.0 * updated yml and README.md * fixed type in README.md description. * updated unit tests. * updated response attributes for download, update and delete custom script. Updated test data and formatted YML. * fixed mypy error in download_custom_script action. * updated reference for status in delete and update custom script actions. * updated link to support sandbox analysis file types. * updated docker image to updated pytmv1 package 0.8.0 * added dockerimage devdemisto/trend-pytmv1:0.8.0.86567 in yml. * Update Packs/TrendMicroVisionOne/Integrations/TrendMicroVisionOneV3/TrendMicroVisionOneV3.yml Co-authored-by: Yuval Hayun <70104171+YuvHayun@users.noreply.github.com> * Update Packs/TrendMicroVisionOne/Integrations/TrendMicroVisionOneV3/TrendMicroVisionOneV3.yml Co-authored-by: Yuval Hayun <70104171+YuvHayun@users.noreply.github.com> * Update Packs/TrendMicroVisionOne/Integrations/TrendMicroVisionOneV3/TrendMicroVisionOneV3.yml Co-authored-by: Yuval Hayun <70104171+YuvHayun@users.noreply.github.com> * added recommended changes. * updated README.md with cortex convention for action names. * updated dockerimage to demisto/pytmv1:0.8.0.87051 * added given-when-then docs for custom script actions and updated yml,README.md, and release notes. * reverted param name to endpoint in get_endpoint_info to avoid breaking changes. * added ip to secrets ignore. * fixed secrets format * updated add_note, update_status, get_endpoint and get_email activity data actions. * updated docker image to demisto/pytmv1:0.8.1.88013 * Update Packs/TrendMicroVisionOne/ReleaseNotes/4_1_0.md Updated release notes per YuvHayun's suggestion. Co-authored-by: Yuval Hayun <70104171+YuvHayun@users.noreply.github.com> * updated record.json() to model_dump_json in fetch_incidents per update in BaseModel class. * updated descriptions for required arguments for get-endpoint-info in README.md and yml * updated argument description for endpoint-info,endpoint and email-activity-data,endpoint and email-activity-data-count and get-custom-script * updated error description for download,delete custom script actions and added predefined value for query_op in get_custom_script_list. * added list options for filetype and shortened description. * added dropdown options for filetype in get custom script list as suggested. * updated dockerimage to pytmv1:0.8.2.89444 * updated release notes to reflect correct dockerimage number. --------- Co-authored-by: Yuval Hayun <70104171+YuvHayun@users.noreply.github.com>
content-bot
added
Contribution
YuvHayun
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original External PR
external pull request
Contributor
@shaqnawe
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: link to the issue
Description
Updated incoming mapper attributes. Updated pytmv1 package to 0.8.0 to support 6 new custom script actions. Fixed an issue with endpoint and email activity data count actions, where query_op was not being parsed correctly. This integration will use the dockerfiles docker image here: updated pytmv1 to 0.8.0 #23882
Must have