EXPANDR-8024: Additional Azure Remediation Bug Fix and Improvements #33039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
content-bot
added
Contribution
content-bot
changed the base branch from
master
to
contrib/PaloAltoNetworks_Azure-EXPANDR-8024
|
@ShirleyDenkberg , can you please review? |
content-bot
added
Community
Contribution Form Filled
|
@merit-maita , shared a demo video with you on drive |
|
@johnnywilkes please share with @moishce |
Packs/Azure-Enrichment-Remediation/Playbooks/Azure_-_Network_Security_Group_Remediation.yml
Outdated
Show resolved
Hide resolved
.../Azure-Enrichment-Remediation/Playbooks/Azure_-_Network_Security_Group_Remediation_README.md
Outdated
Show resolved
Hide resolved
.../Azure-Enrichment-Remediation/Playbooks/Azure_-_Network_Security_Group_Remediation_README.md
Outdated
Show resolved
Hide resolved
|
@moishce Doc review completed. |
@moishce , I shared demo video with you via drive |
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
moishce
reviewed
Feb 25, 2024
| @@ -828,6 +840,8 @@ tasks: | |||
| applyIfEmpty: {} | |||
| defaultValue: {} | |||
| operator: SetIfEmpty | |||
| using: | |||
| simple: ${inputs.instance_name} | |||
There was a problem hiding this comment.
Suggested change
| simple: ${inputs.instance_name} | |
| simple: ${inputs.InstanceName} |
You might want to change it to title case like the other inputs.
There was a problem hiding this comment.
@moishce , fixed in @johnnywilkes
update input name
moishce
reviewed
Feb 25, 2024
There was a problem hiding this comment.
Hi @johnnywilkes ,
Thank you for your contribution!
Good work :)
Just one small note
@melamedbn, do you want to go over it?
moishce
approved these changes
Feb 26, 2024
moishce
merged commit 5351a7b
into
demisto:contrib/PaloAltoNetworks_Azure-EXPANDR-8024
19 of 21 checks passed
5 tasks
|
Thank you for your contribution. Your external PR has been merged and the changes are now included in an internal PR for further review. The internal PR will be merged to the master branch within 3 business days. |
moishce
added a commit
that referenced
this pull request
Feb 28, 2024
…33039) (#33112) * update play * RN * Apply suggestions from code review * update input name --------- Co-authored-by: johnnywilkes <32227961+johnnywilkes@users.noreply.github.com> Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> Co-authored-by: Moshe Galitzky <112559840+moishce@users.noreply.github.com>
rundssoar
pushed a commit
to rundssoar/content
that referenced
this pull request
Feb 28, 2024
…emisto#33039) (demisto#33112) * update play * RN * Apply suggestions from code review * update input name --------- Co-authored-by: johnnywilkes <32227961+johnnywilkes@users.noreply.github.com> Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> Co-authored-by: Moshe Galitzky <112559840+moishce@users.noreply.github.com>
maimorag
pushed a commit
that referenced
this pull request
Feb 28, 2024
…33039) (#33112) * update play * RN * Apply suggestions from code review * update input name --------- Co-authored-by: johnnywilkes <32227961+johnnywilkes@users.noreply.github.com> Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> Co-authored-by: Moshe Galitzky <112559840+moishce@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
https://jira-dc.paloaltonetworks.com/browse/EXPANDR-8024
https://jira-dc.paloaltonetworks.com/browse/EXPANDR-8187
https://jira-dc.paloaltonetworks.com/browse/EXPANDR-8180
Description
remediation-allow-port-<port#>-<tcp|udp>Azure NSG rule to be created.Must have