New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EXPANDR-8024: Additional Azure Remediation Bug Fix and Improvements #33039
Merged
moishce
merged 7 commits into
demisto:contrib/PaloAltoNetworks_Azure-EXPANDR-8024
from
PaloAltoNetworks:Azure-EXPANDR-8024
Feb 26, 2024
Merged
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
e01a8ad
update play
johnnywilkes e07824e
RN
johnnywilkes 12a1ce1
Apply suggestions from code review
johnnywilkes 4a34941
Merge branch 'contrib/PaloAltoNetworks_Azure-EXPANDR-8024' into Azure…
johnnywilkes 6aa4925
Merge branch 'contrib/PaloAltoNetworks_Azure-EXPANDR-8024' into Azure…
johnnywilkes 0cb36b1
update input name
johnnywilkes ad8ed29
Merge branch 'contrib/PaloAltoNetworks_Azure-EXPANDR-8024' into Azure…
johnnywilkes File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
[file:Azure_-_Network_Security_Group_Remediation.yml] | ||
ignore=PB106 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
|
||
#### Playbooks | ||
|
||
##### Azure - Network Security Group Remediation | ||
|
||
- Added the *instance_name* optional playbook input to allow user to specify Azure Network Security Groups integration instance to use. | ||
johnnywilkes marked this conversation as resolved.
Show resolved
Hide resolved
|
||
- Added the *RemediationAllowRanges* optional playbook input to allow user to specify IPv4 network ranges to be used as source addresses for the `remediation-allow-port-<port#>-<tcp|udp>` Azure NSG rule to be created. | ||
johnnywilkes marked this conversation as resolved.
Show resolved
Hide resolved
|
||
- Fixed an issue with not being able to detect all offending rules. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might want to change it to title case like the other inputs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@moishce , fixed in @johnnywilkes
update input name