-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Indicator Layouts cherry pick #4144
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuvalbenshalom
requested changes
Aug 19, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see my comments
Scripts/IndicatorRelatedIncientBySeverity/IndicatorRelatedIncientBySeverity.yml
Outdated
Show resolved
Hide resolved
Scripts/NumberOfPhishingAttemptPerUser/NumberOfPhishingAttemptPerUser.yml
Outdated
Show resolved
Hide resolved
Scripts/PositiveDetectionsVSDetectionEngines/PositiveDetectionsVSDetectionEngines.yml
Outdated
Show resolved
Hide resolved
yuvalbenshalom
approved these changes
Aug 19, 2019
Alex's team will need to manually add reviewed RN to the release draft, is he aware of that? |
yardensade
approved these changes
Aug 19, 2019
@DeanArbel @yardensade All changelog items added to 19.8.1 RNs manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready
Description
Cherry picked 33 files from master (the files that were created in #4084)