Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicator Layouts cherry pick #4144

Merged
merged 4 commits into from
Aug 20, 2019
Merged

Indicator Layouts cherry pick #4144

merged 4 commits into from
Aug 20, 2019

Conversation

DeanArbel
Copy link
Contributor

Status

Ready

Description

Cherry picked 33 files from master (the files that were created in #4084)

Copy link
Contributor

@yuvalbenshalom yuvalbenshalom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comments

@yardensade
Copy link
Contributor

Alex's team will need to manually add reviewed RN to the release draft, is he aware of that?

@yardensade
Copy link
Contributor

@kirbles19

@kirbles19
Copy link
Contributor

@DeanArbel @yardensade All changelog items added to 19.8.1 RNs manually.

@DeanArbel DeanArbel merged commit ad565d2 into 19.8.1 Aug 20, 2019
@DeanArbel DeanArbel deleted the layouts_cherry branch August 20, 2019 07:21
@yardensade
Copy link
Contributor

This happens in the build atm, do we know why?
image

@yardensade
Copy link
Contributor

@DeanArbel @yuvalbenshalom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants