Fix base url #34
Merged
Fix base url #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeanArbel
requested changes
Mar 19, 2020
CHANGELOG.md
Outdated
| @@ -4,7 +4,8 @@ | |||
|
|
|||
| [1]: https://pypi.org/project/demisto-py/#history | |||
| ## 2.0.9 | |||
| Improved error message when missing authentication parameters. | |||
| * Improved error message when missing authentication parameters. | |||
| * fix base_url slash inconsistency | |||
There was a problem hiding this comment.
It's configuration.host and not base_url
There was a problem hiding this comment.
sure, fixing it.
There was a problem hiding this comment.
I tested generic_request_func directly with the next options:
- base/ + /path
2.base + / path
- base + path
4.base/ + path
glicht
reviewed
Mar 20, 2020
| @@ -4,7 +4,8 @@ | |||
|
|
|||
| [1]: https://pypi.org/project/demisto-py/#history | |||
| ## 2.0.9 | |||
| Improved error message when missing authentication parameters. | |||
| * Improved error message when missing authentication parameters. | |||
There was a problem hiding this comment.
Add the change log entries to a new version: 2.0.10. 2.0.9 was released alread.
amshamah419
approved these changes
Mar 22, 2020
CHANGELOG.md
Outdated
| @@ -3,8 +3,11 @@ | |||
| [PyPI History][1] | |||
|
|
|||
| [1]: https://pypi.org/project/demisto-py/#history | |||
| ## 2.0.10 | |||
| * fix configuration.host slash inconsistency | |||
There was a problem hiding this comment.
Suggested change
| * fix configuration.host slash inconsistency | |
| * Enabled host and path parameters to function with trailing or leading slashes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready
Fixes
https://github.com/demisto/etc/issues/22837
Description
DEMISTO_BASE_URL slash inconsistency
Must have