Add reputation routes #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorschw
approved these changes
Aug 14, 2022
Comment on lines
+4571
to
+4572
| if ('file' not in params or | ||
| params['file'] is None): |
There was a problem hiding this comment.
Suggested change
| if ('file' not in params or | |
| params['file'] is None): | |
| if params.get('file') is None: |
There was a problem hiding this comment.
Generally we don't modify the files manually since the project is supposed to be generated purely by a new server version.
| form_params = [] | ||
| local_var_files = {} | ||
| if 'file' in params: | ||
| local_var_files['file'] = params['file'] # noqa: E501 |
There was a problem hiding this comment.
don't we raise ValueError if it is not there?
There was a problem hiding this comment.
I think in the future I will see if we can bump the version of the tool we are using, but that will be a relatively big effort since everything that uses demisto-py will need to be validated.
Ideally a version bump will lead to better syntax here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready
Related Issues
fixes: internal
Description
Adds ability to upload reputations
Must have