Skip to content

Commit

Permalink
Xsiam datasource readme (#4305)
Browse files Browse the repository at this point in the history
* Adding the defaultDataSource field to the pack metadata (#4139)

* Add validation

* Change to reflect prior logic

* Merge remote-tracking branch 'origin/datasource-feature' into datasource-feature

# Conflicts:
#	.pre-commit-config.yaml

* fix conflicts

* Fix UT

* rename defaultDataSourceName

* add defaultDataSourceName to metadata

* fix validation

* precommit

* add is valid default datasource name validator

* add integration doc

* add validations to lists

* fix PA131

* add fix for PA131

* raise Exception in fix PA131

* fix PA132

* more logs

* add data source id

* run pre-commit

* support contribution display name

* handle contrib display name

* enhance get_valid_data_source_integrations

* add is_data_source to integration

* fix contrib name

* post-demo - keep default

* logs

* change defaultDataSource to dict

* change field to str

* remove Field

* exclude Field

* exclude Field

* add UT

* CR

* fix UTs

* fix field alias

* remove exclude field

* remove Field

* exclude name

* CR error

* change to error error

* Field alias

* rename fields

* revert _

* deal with XSOAR

* add marketplace

* fix generate docs

* fix generate docs

---------

Authored-by: BEAdi <72088126+BEAdi@users.noreply.github.com>

* remove XSIAM tag

* Adding the defaultDataSource field to the pack metadata (#4139)

* Add validation

* Change to reflect prior logic

* Merge remote-tracking branch 'origin/datasource-feature' into datasource-feature

# Conflicts:
#	.pre-commit-config.yaml

* fix conflicts

* Fix UT

* rename defaultDataSourceName

* add defaultDataSourceName to metadata

* fix validation

* precommit

* add is valid default datasource name validator

* add integration doc

* add validations to lists

* fix PA131

* add fix for PA131

* raise Exception in fix PA131

* fix PA132

* more logs

* add data source id

* run pre-commit

* support contribution display name

* handle contrib display name

* enhance get_valid_data_source_integrations

* add is_data_source to integration

* fix contrib name

* post-demo - keep default

* logs

* change defaultDataSource to dict

* change field to str

* remove Field

* exclude Field

* exclude Field

* add UT

* CR

* fix UTs

* fix field alias

* remove exclude field

* remove Field

* exclude name

* CR error

* change to error error

* Field alias

* rename fields

* revert _

* deal with XSOAR

* add marketplace

* fix generate docs

* fix generate docs

---------

Authored-by: BEAdi <72088126+BEAdi@users.noreply.github.com>

* remove XSIAM tag

* remove XSIAM tag
  • Loading branch information
BEAdi committed May 28, 2024
1 parent adf7fdc commit 6f18991
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .changelog/4302.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
changes:
- description: Removed support for the `defaultDataSource` field in the pack metadata for hybrid packs.
type: feature
pr_number: 4139
pr_number: 4302
4 changes: 4 additions & 0 deletions .changelog/4305.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
changes:
- description: Added XSIAM prefix for the `defaultDataSource` integration README.
type: feature
pr_number: 4305
Original file line number Diff line number Diff line change
Expand Up @@ -558,9 +558,8 @@ def generate_integration_doc(
if yml_data.get("commonfields", {}).get("id") == default_data_source_id:
docs.extend(
[
"<~XSIAM>",
"This is the default integration for this content pack when configured by the Data Onboarder.",
"</~XSIAM>",
"This is the default integration for this content pack when configured by the Data Onboarder "
"in Cortex XSIAM.",
"",
]
)
Expand Down

0 comments on commit 6f18991

Please sign in to comment.