Adding the defaultDataSource field to the pack metadata #4139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changelog(s) in markdown:
|
…rce-feature # Conflicts: # .pre-commit-config.yaml
demisto_sdk/commands/validate/validators/PA_validators/PA131_is_default_datasource.py
Outdated
Show resolved
Hide resolved
|
@yuvalbenshalom @dantavori @ilaner Doc review completed. |
5 tasks
jbabazadeh
requested changes
May 22, 2024
jbabazadeh
requested changes
May 22, 2024
demisto_sdk/commands/validate/validators/PA_validators/PA131_is_default_data_source_provided.py
Outdated
Show resolved
Hide resolved
demisto_sdk/commands/validate/validators/PA_validators/PA131_is_default_data_source_provided.py
Outdated
Show resolved
Hide resolved
demisto_sdk/commands/validate/validators/PA_validators/PA131_is_default_data_source_provided.py
Outdated
Show resolved
Hide resolved
demisto_sdk/commands/validate/validators/PA_validators/PA132_is_valid_default_datasource.py
Show resolved
Hide resolved
demisto_sdk/commands/validate/validators/PA_validators/PA132_is_valid_default_datasource.py
Outdated
Show resolved
Hide resolved
jbabazadeh
approved these changes
May 27, 2024
BEAdi
added a commit
that referenced
this pull request
May 28, 2024
* Add validation * Change to reflect prior logic * Merge remote-tracking branch 'origin/datasource-feature' into datasource-feature # Conflicts: # .pre-commit-config.yaml * fix conflicts * Fix UT * rename defaultDataSourceName * add defaultDataSourceName to metadata * fix validation * precommit * add is valid default datasource name validator * add integration doc * add validations to lists * fix PA131 * add fix for PA131 * raise Exception in fix PA131 * fix PA132 * more logs * add data source id * run pre-commit * support contribution display name * handle contrib display name * enhance get_valid_data_source_integrations * add is_data_source to integration * fix contrib name * post-demo - keep default * logs * change defaultDataSource to dict * change field to str * remove Field * exclude Field * exclude Field * add UT * CR * fix UTs * fix field alias * remove exclude field * remove Field * exclude name * CR error * change to error error * Field alias * rename fields * revert _ * deal with XSOAR * add marketplace * fix generate docs * fix generate docs --------- Authored-by: BEAdi <72088126+BEAdi@users.noreply.github.com>
BEAdi
added a commit
that referenced
this pull request
May 28, 2024
* Add validation * Change to reflect prior logic * Merge remote-tracking branch 'origin/datasource-feature' into datasource-feature # Conflicts: # .pre-commit-config.yaml * fix conflicts * Fix UT * rename defaultDataSourceName * add defaultDataSourceName to metadata * fix validation * precommit * add is valid default datasource name validator * add integration doc * add validations to lists * fix PA131 * add fix for PA131 * raise Exception in fix PA131 * fix PA132 * more logs * add data source id * run pre-commit * support contribution display name * handle contrib display name * enhance get_valid_data_source_integrations * add is_data_source to integration * fix contrib name * post-demo - keep default * logs * change defaultDataSource to dict * change field to str * remove Field * exclude Field * exclude Field * add UT * CR * fix UTs * fix field alias * remove exclude field * remove Field * exclude name * CR error * change to error error * Field alias * rename fields * revert _ * deal with XSOAR * add marketplace * fix generate docs * fix generate docs --------- Authored-by: BEAdi <72088126+BEAdi@users.noreply.github.com>
BEAdi
added a commit
that referenced
this pull request
May 28, 2024
* Add validation * Change to reflect prior logic * Merge remote-tracking branch 'origin/datasource-feature' into datasource-feature # Conflicts: # .pre-commit-config.yaml * fix conflicts * Fix UT * rename defaultDataSourceName * add defaultDataSourceName to metadata * fix validation * precommit * add is valid default datasource name validator * add integration doc * add validations to lists * fix PA131 * add fix for PA131 * raise Exception in fix PA131 * fix PA132 * more logs * add data source id * run pre-commit * support contribution display name * handle contrib display name * enhance get_valid_data_source_integrations * add is_data_source to integration * fix contrib name * post-demo - keep default * logs * change defaultDataSource to dict * change field to str * remove Field * exclude Field * exclude Field * add UT * CR * fix UTs * fix field alias * remove exclude field * remove Field * exclude name * CR error * change to error error * Field alias * rename fields * revert _ * deal with XSOAR * add marketplace * fix generate docs * fix generate docs --------- Authored-by: BEAdi <72088126+BEAdi@users.noreply.github.com>
BEAdi
added a commit
that referenced
this pull request
May 28, 2024
* Adding the defaultDataSource field to the pack metadata (#4139) * Add validation * Change to reflect prior logic * Merge remote-tracking branch 'origin/datasource-feature' into datasource-feature # Conflicts: # .pre-commit-config.yaml * fix conflicts * Fix UT * rename defaultDataSourceName * add defaultDataSourceName to metadata * fix validation * precommit * add is valid default datasource name validator * add integration doc * add validations to lists * fix PA131 * add fix for PA131 * raise Exception in fix PA131 * fix PA132 * more logs * add data source id * run pre-commit * support contribution display name * handle contrib display name * enhance get_valid_data_source_integrations * add is_data_source to integration * fix contrib name * post-demo - keep default * logs * change defaultDataSource to dict * change field to str * remove Field * exclude Field * exclude Field * add UT * CR * fix UTs * fix field alias * remove exclude field * remove Field * exclude name * CR error * change to error error * Field alias * rename fields * revert _ * deal with XSOAR * add marketplace * fix generate docs * fix generate docs --------- Authored-by: BEAdi <72088126+BEAdi@users.noreply.github.com> * remove XSIAM tag * Adding the defaultDataSource field to the pack metadata (#4139) * Add validation * Change to reflect prior logic * Merge remote-tracking branch 'origin/datasource-feature' into datasource-feature # Conflicts: # .pre-commit-config.yaml * fix conflicts * Fix UT * rename defaultDataSourceName * add defaultDataSourceName to metadata * fix validation * precommit * add is valid default datasource name validator * add integration doc * add validations to lists * fix PA131 * add fix for PA131 * raise Exception in fix PA131 * fix PA132 * more logs * add data source id * run pre-commit * support contribution display name * handle contrib display name * enhance get_valid_data_source_integrations * add is_data_source to integration * fix contrib name * post-demo - keep default * logs * change defaultDataSource to dict * change field to str * remove Field * exclude Field * exclude Field * add UT * CR * fix UTs * fix field alias * remove exclude field * remove Field * exclude name * CR error * change to error error * Field alias * rename fields * revert _ * deal with XSOAR * add marketplace * fix generate docs * fix generate docs --------- Authored-by: BEAdi <72088126+BEAdi@users.noreply.github.com> * remove XSIAM tag * remove XSIAM tag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
fixes:https://jira-dc.paloaltonetworks.com/browse/CIAC-9753
Description