Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isort #324

Merged
merged 12 commits into from
Apr 5, 2020
Merged

isort #324

merged 12 commits into from
Apr 5, 2020

Conversation

Itay4
Copy link
Contributor

@Itay4 Itay4 commented Apr 3, 2020

Status

  • Ready

Description

  • Added isort to pre-commit hooks and extractor
  • Fixed a regression from Split yml powershell support #316 in which the the suffix .py was not added to the file name and autopep8 got wrong file name

Must have

  • Tests

@Itay4 Itay4 requested a review from glicht April 3, 2020 09:16
Copy link
Contributor

@glicht glicht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@Itay4
Copy link
Contributor Author

Itay4 commented Apr 5, 2020

@glicht ive sorted the imports in all the repo, if you would like to review again

@coveralls
Copy link
Collaborator

coveralls commented Apr 5, 2020

Pull Request Test Coverage Report for Build 2290

  • 182 of 224 (81.25%) changed or added relevant lines in 57 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 56.338%

Changes Missing Coverage Covered Lines Changed/Added Lines %
demisto_sdk/commands/common/hook_validations/classifier.py 0 1 0.0%
demisto_sdk/commands/run_playbook/playbook_runner.py 0 1 0.0%
demisto_sdk/commands/common/hook_validations/description.py 0 2 0.0%
demisto_sdk/commands/split_yml/extractor.py 7 9 77.78%
demisto_sdk/commands/init/initiator.py 0 6 0.0%
demisto_sdk/commands/validate/file_validator.py 0 14 0.0%
demisto_sdk/main.py 0 16 0.0%
Files with Coverage Reduction New Missed Lines %
demisto_sdk/commands/validate/file_validator.py 1 0%
Totals Coverage Status
Change from base Build 2288: 0.2%
Covered Lines: 4262
Relevant Lines: 7565

💛 - Coveralls

@Itay4 Itay4 merged commit bf37e81 into master Apr 5, 2020
@Itay4 Itay4 deleted the isort branch April 5, 2020 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants