Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add python version for content graph #3339

Merged
merged 117 commits into from Sep 5, 2023
Merged

Add python version for content graph #3339

merged 117 commits into from Sep 5, 2023

Conversation

GuyAfik
Copy link
Contributor

@GuyAfik GuyAfik commented Jul 19, 2023 •
edited

Related Issues

fixes: https://jira-hq.paloaltonetworks.local/browse/CIAC-7277

Description

Add the python_version field to the graph for each integration/script as long as they use a python image.

@coveralls
Copy link
Collaborator

coveralls commented Jul 19, 2023 •
edited

Pull Request Test Coverage Report for Build b50b67d1-125d-46e1-8f4d-28a21af09bc0

  • 133 of 146 (91.1%) changed or added relevant lines in 13 files are covered.
  • 22 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.03%) to 81.128%
Changes Missing Coverage Covered Lines Changed/Added Lines %
demisto_sdk/commands/common/docker_helper.py 26 27 96.3%
demisto_sdk/commands/common/singleton.py 9 10 90.0%
demisto_sdk/commands/common/tools.py 2 3 66.67%
demisto_sdk/commands/content_graph/common.py 11 12 91.67%
demisto_sdk/commands/content_graph/objects/integration_script.py 6 7 85.71%
demisto_sdk/commands/pre_commit/pre_commit_command.py 4 5 80.0%
demisto_sdk/commands/common/docker_images_metadata.py 42 45 93.33%
demisto_sdk/commands/content_graph/objects/base_content.py 4 8 50.0%
Files with Coverage Reduction New Missed Lines %
demisto_sdk/commands/content_graph/objects/base_content.py 1 66.39%
demisto_sdk/commands/common/docker_helper.py 21 57.71%
Totals Coverage Status
Change from base Build 037e2d90-3dd2-41b2-b9b8-8e1226f26088: -0.03%
Covered Lines: 31717
Relevant Lines: 39095
💛 - Coveralls

@GuyAfik GuyAfik marked this pull request as draft July 19, 2023 14:40
dorschw
dorschw reviewed Jul 23, 2023
View reviewed changes
demisto_sdk/__main__.py Outdated Show resolved Hide resolved
demisto_sdk/__main__.py Outdated Show resolved Hide resolved
@guardrails
Copy link

guardrails bot commented Aug 10, 2023 •
edited

All previously detected findings have been fixed. Good job! 👍🎉

We will keep this comment up-to-date as you go along and notify you of any security issues that we identify.

👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@GuyAfik GuyAfik requested a review from dantavori August 22, 2023 07:33
JudahSchwartz
JudahSchwartz approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@JudahSchwartz JudahSchwartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice

demisto_sdk/commands/common/docker_helper.py Outdated Show resolved Hide resolved
demisto_sdk/commands/common/docker_helper.py Outdated Show resolved Hide resolved
demisto_sdk/commands/content_graph/common.py Show resolved Hide resolved
demisto_sdk/commands/content_graph/tests/parsers_and_models_test.py
# make sure that the python_version is not in the model because it was called directly
assert "python_version" not in str(model)

assert model.python_version == expected_python_version
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice test

@GuyAfik GuyAfik requested a review from kobymeir August 27, 2023 12:17
dantavori
dantavori reviewed Aug 27, 2023
View reviewed changes
Copy link
Contributor

@dantavori dantavori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, see (mainly cosmetic) notes below

demisto_sdk/commands/common/docker_helper.py Outdated Show resolved Hide resolved
demisto_sdk/commands/common/docker_helper.py Show resolved Hide resolved
demisto_sdk/commands/content_graph/common.py Show resolved Hide resolved
demisto_sdk/commands/content_graph/objects/base_content.py Outdated Show resolved Hide resolved
demisto_sdk/commands/content_graph/objects/base_content.py Show resolved Hide resolved
demisto_sdk/commands/content_graph/objects/integration_script.py Outdated Show resolved Hide resolved
@GuyAfik GuyAfik requested a review from dantavori August 28, 2023 07:54
@GuyAfik GuyAfik merged commit 38bd9c7 into master Sep 5, 2023
18 checks passed
@GuyAfik GuyAfik deleted the add_python_version_graph branch September 5, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dorschw dorschw dorschw left review comments

@ilaner ilaner ilaner left review comments

@kobymeir kobymeir kobymeir approved these changes

@JudahSchwartz JudahSchwartz JudahSchwartz approved these changes

@dantavori dantavori Awaiting requested review from dantavori dantavori is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
7 participants
@GuyAfik @coveralls @kobymeir @JudahSchwartz @dantavori @dorschw @ilaner