Add Update Release Notes command #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2979
💛 - Coveralls |
|
@yuvalbenshalom More critically, this includes the fix to allow markdown files to be added to the |
yuvalbenshalom
requested changes
Apr 29, 2020
| pre_release=pre_release) | ||
| update_pack_rn.execute_update() | ||
| elif is_all and _pack: | ||
| print_error(f"Please remove the --all flag when specifying only one pack.") |
demisto_sdk/commands/update_release_notes/tests/update_rn_test.py
Outdated
Show resolved
Hide resolved
demisto_sdk/commands/update_release_notes/tests/update_rn_test.py
Outdated
Show resolved
Hide resolved
| else: | ||
| name = os.path.basename(file_path) | ||
| print_error(f"Could not find name in {file_path}") | ||
| # sys.exit(1) |
There was a problem hiding this comment.
It's for cases where a yml or json doesn't contain the entity name. I could remove the print, or make the message more clear if that works
|
|
||
| @staticmethod | ||
| def find_corresponding_yml(file_path): | ||
| if file_path.endswith('.py'): |
There was a problem hiding this comment.
question, should this be relevant to other files in the pack? why just py/yml?
There was a problem hiding this comment.
Py files don't have a file structure where I can extract the display name so I know that if we get a python file in the git diff, it's either a script or an integration which should have the display name in the yml. The code above is to load the yml file path so we can pull the display name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Related Issues
fixes: demisto/etc#22984
Description
Added the
demisto-sdk update-release-notescommand.Must have