-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generalize the mode option in pre-commit #3765
Generalize the mode option in pre-commit #3765
Conversation
Pull Request Test Coverage Report for Build 49253157-87b1-4a06-852f-41acd43a9f61
💛 - Coveralls |
""" | ||
if self.mode == PreCommitModes.NIGHTLY and self.all_files: | ||
self.base_hook["args"].append("-a") | ||
if self.mode and self.mode.lower() == "nightly" and self.all_files: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this couldnt be fixed with modes?
I didnt review the coverage code itself |
if hook.get("docker_image"): | ||
hook.pop("docker_image") | ||
if hook.get("config_file_arg"): | ||
hook.pop("config_file_arg") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have a test that tests the final formation of the hooks dict?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work on this 1. nice end product despite the changing requirements 🚀
Related Issues
fixes:https://jira-dc.paloaltonetworks.com/browse/CIAC-8764
Description
Support the option of having multiple modes per hook (not just nightly mode).