Generalize the mode option in pre-commit #3765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 49253157-87b1-4a06-852f-41acd43a9f61
💛 - Coveralls |
5 tasks
| """ | ||
| if self.mode == PreCommitModes.NIGHTLY and self.all_files: | ||
| self.base_hook["args"].append("-a") | ||
| if self.mode and self.mode.lower() == "nightly" and self.all_files: |
There was a problem hiding this comment.
this couldnt be fixed with modes?
|
I didnt review the coverage code itself |
eyalpalo
requested changes
Nov 9, 2023
| if hook.get("docker_image"): | ||
| hook.pop("docker_image") | ||
| if hook.get("config_file_arg"): | ||
| hook.pop("config_file_arg") |
There was a problem hiding this comment.
Do we have a test that tests the final formation of the hooks dict?
eyalpalo
approved these changes
Nov 12, 2023
JudahSchwartz
requested changes
Nov 16, 2023
JudahSchwartz
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
fixes:https://jira-dc.paloaltonetworks.com/browse/CIAC-8764
Description
Support the option of having multiple modes per hook (not just nightly mode).