New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace ec2-user with gcp-user (demisto-sdk) #3828
Replace ec2-user with gcp-user (demisto-sdk) #3828
Conversation
Pull Request Test Coverage Report for Build 8313971399Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Changelog(s) in markdown:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one comment.
@@ -251,6 +251,9 @@ def push_mock_files(self): | |||
f"Failed pushing mock files with error: {exc}", real_time=True | |||
) | |||
finally: | |||
self.logging_module.debug( | |||
"Successfully pushed new/updated mock files to mock git repo.", real_time=True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we actually know it was successful if it is in the finally section?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, we don't. While there are logs for when an Exception is caught, we can't reliably confirm the success of the push, which might be misleading. Removing this log.
Changelog(s) in markdown:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Related Issues
relates: CIAC-8955
Description
This PR introduces the following changes:
ec2-user
togcp-user
.