Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ec2-user with gcp-user (demisto-sdk) #3828

Merged
merged 33 commits into from Mar 18, 2024

Conversation

samuelFain
Copy link
Contributor

@samuelFain samuelFain commented Nov 28, 2023

Related Issues

relates: CIAC-8955

Description

This PR introduces the following changes:

  • Update file paths in demisto-sdk which used ec2-user to gcp-user.
  • Grant correct permissions to commit and push changes in the mock files repo (more information in Jira ticket).

@samuelFain samuelFain self-assigned this Nov 28, 2023
@coveralls
Copy link
Collaborator

coveralls commented Nov 28, 2023

Pull Request Test Coverage Report for Build 8313971399

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 27 unchanged lines in 9 files lost coverage.
  • Overall coverage increased (+11.7%) to 92.213%

Files with Coverage Reduction New Missed Lines %
demisto_sdk/commands/content_graph/objects/pack.py 1 99.65%
demisto_sdk/commands/content_graph/objects/base_content.py 1 99.31%
demisto_sdk/commands/pre_commit/pre_commit_command.py 1 99.67%
demisto_sdk/commands/validate/validators/DO_validators/DO104_docker_image_does_not_exist_in_yml.py 1 93.1%
demisto_sdk/commands/content_graph/objects/content_item.py 1 95.59%
demisto_sdk/commands/content_graph/objects/integration_script.py 4 95.4%
demisto_sdk/commands/content_graph/objects/integration.py 4 96.83%
demisto_sdk/commands/validate/validators/DO_validators/DO106_docker_image_is_latest_tag.py 7 78.79%
demisto_sdk/commands/common/docker_helper.py 7 96.19%
Totals Coverage Status
Change from base Build 108c8881-b3c1-4ae6-9857-270dcec305f0: 11.7%
Covered Lines: 59296
Relevant Lines: 64303

💛 - Coveralls

@samuelFain samuelFain changed the title Replace ec2-user with gcp-user Replace ec2-user with gcp-user (demisto-sdk) Nov 28, 2023
Copy link

Changelog(s) in markdown:

  • Update file paths in test_content from ec2-user to gcp-user. #3828

Copy link
Contributor

@JasBeilin JasBeilin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one comment.

@@ -251,6 +251,9 @@ def push_mock_files(self):
f"Failed pushing mock files with error: {exc}", real_time=True
)
finally:
self.logging_module.debug(
"Successfully pushed new/updated mock files to mock git repo.", real_time=True
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we actually know it was successful if it is in the finally section?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we don't. While there are logs for when an Exception is caught, we can't reliably confirm the success of the push, which might be misleading. Removing this log.

Copy link

Changelog(s) in markdown:

  • Update file paths in test_content from ec2-user to gcp-user. #3828

Copy link
Contributor

@JasBeilin JasBeilin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@samuelFain samuelFain merged commit 0e3d231 into master Mar 18, 2024
21 checks passed
@samuelFain samuelFain deleted the devbug/CIAC-8955/replace-ec3-user-in-demisto-sdk branch March 18, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants