-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace ec2-user with gcp-user (demisto-sdk) #3828
Merged
samuelFain
merged 33 commits into
master
from
devbug/CIAC-8955/replace-ec3-user-in-demisto-sdk
Mar 18, 2024
Merged
Changes from 30 commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
253c2ab
Replace ec2-user with gcp-user
samuelFain 971f52c
update poetry.lock
samuelFain 460b6df
Merge branch 'master' into devbug/CIAC-8955/replace-ec3-user-in-demis…
samuelFain eb69da3
checkout poetry.lock from master
samuelFain 1cc0965
Merge branch 'master' into devbug/CIAC-8955/replace-ec3-user-in-demis…
samuelFain fe2010b
checkout poetry.lock from master
samuelFain 0b21b4c
testing logging in mock_server.py
samuelFain 0aa87d1
add logs to mock_server_py
samuelFain d9d4b2c
Add logs
samuelFain 763da33
Change lo_warning to log_info
samuelFain dc830b3
Add logs
samuelFain e9fec8e
Add logs
samuelFain dc4367e
Add logs to move_mock_file_to_repo
samuelFain eb5d720
Fix broken logs
samuelFain 7081075
Add commit_mock_file function logs
samuelFain 171b48e
Merge branch 'master' into devbug/CIAC-8955/replace-ec3-user-in-demis…
samuelFain c993b5a
Add logs
samuelFain 8fee659
Update mock repo on all branches and not just master
samuelFain 01e0164
Merge branch 'master' into devbug/CIAC-8955/replace-ec3-user-in-demis…
samuelFain 5b75ec0
Add logs to push_mock_files
samuelFain f1ebe8d
Remove log that caused attribute error
samuelFain 0452d04
Merge branch 'master' into devbug/CIAC-8955/replace-ec3-user-in-demis…
samuelFain 16e4b21
Merge branch 'master' into devbug/CIAC-8955/replace-ec3-user-in-demis…
samuelFain 5230cbf
Revert init changes in MITMProxy
samuelFain 708c054
Remove debug logs
samuelFain 310d9df
Remove redundant debugging logs and variables
samuelFain 2608cb1
Revert redundant spacing
samuelFain ed5c908
Remove redundant import
samuelFain 880663a
Merge branch 'master' into devbug/CIAC-8955/replace-ec3-user-in-demis…
samuelFain 0f214f9
Add changelog file
samuelFain 86119a9
Remove misleading log; Format
samuelFain 9656e04
Merge branch 'master' into devbug/CIAC-8955/replace-ec3-user-in-demis…
samuelFain 5324015
Update 3828.yml
samuelFain File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
changes: | ||
- description: Update file paths in test_content from ec2-user to gcp-user. | ||
type: fix | ||
pr_number: 3828 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we actually know it was successful if it is in the finally section?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, we don't. While there are logs for when an Exception is caught, we can't reliably confirm the success of the push, which might be misleading. Removing this log.