Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] - Add default timeouts to cancel hanging jobs #3986

Merged
merged 8 commits into from
Jan 28, 2024

Conversation

GuyAfik
Copy link
Contributor

@GuyAfik GuyAfik commented Jan 28, 2024

Description

  • Do not run validate-changelog when running in master branch as its redundant, works in commit 1a64c34
  • Add default-timeouts of 60 minutes for hanging jobs/steps, that means that If the steps / flows haven't finished in 1 hour, they will be automatically cancelled.
  • Upgrade node to 20 from 16 as 16 is deprecated

@coveralls
Copy link
Collaborator

coveralls commented Jan 28, 2024

Pull Request Test Coverage Report for Build b36fcfc1-9767-406c-acf7-d1a96ba63a73

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 8025 unchanged lines in 290 files lost coverage.
  • Overall coverage decreased (-18.4%) to 80.531%

Files with Coverage Reduction New Missed Lines %
demisto_sdk/commands/common/clients/configs.py 1 97.14%
demisto_sdk/commands/common/content/objects/pack_objects/incident_field/incident_field.py 1 65.0%
demisto_sdk/commands/common/content/objects/pack_objects/job/job.py 1 83.33%
demisto_sdk/commands/common/content/objects/pack_objects/lists/lists.py 1 85.71%
demisto_sdk/commands/common/files/errors.py 1 71.43%
demisto_sdk/commands/common/files/text_file.py 1 78.13%
demisto_sdk/commands/common/hook_validations/deprecation.py 1 98.72%
demisto_sdk/commands/common/hook_validations/job.py 1 98.41%
demisto_sdk/commands/common/hook_validations/layout_rule.py 1 88.89%
demisto_sdk/commands/common/hook_validations/lists.py 1 96.55%
Totals Coverage Status
Change from base Build 7684887448: -18.4%
Covered Lines: 35631
Relevant Lines: 44245

💛 - Coveralls

@GuyAfik GuyAfik requested a review from ilaner January 28, 2024 07:20
@GuyAfik GuyAfik marked this pull request as ready for review January 28, 2024 07:20
Copy link
Contributor

@ilaner ilaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@GuyAfik GuyAfik merged commit 973dda3 into master Jan 28, 2024
29 of 30 checks passed
@GuyAfik GuyAfik deleted the default_cancel_timeout branch January 28, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants