Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] - Add default timeouts to cancel hanging jobs #3986

Merged
merged 8 commits into from
Jan 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/setup_test_environment/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ inputs:
node-version:
required: false
type: string
default: "16"
default: "20"
description: "The node version to install"
artifacts-dir:
required: false
Expand Down
10 changes: 9 additions & 1 deletion .github/workflows/on-push.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ on:
branches:
- "**"


concurrency:
group: tests-${{ github.head_ref || github.ref }}
cancel-in-progress: ${{ github.event_name == 'pull_request' }}
Expand All @@ -16,7 +17,7 @@ concurrency:
jobs:
validate-changelog:
runs-on: ubuntu-latest
if: github.head_ref != 'master'
if: github.ref_name != 'master'
steps:
- name: Checkout
uses: actions/checkout@v4
Expand Down Expand Up @@ -79,6 +80,7 @@ jobs:
artifacts-dir: unit-tests/logs

- name: Run Unit Tests
timeout-minutes: 60
run: |
source "$(poetry env info --path)/bin/activate"

Expand Down Expand Up @@ -123,6 +125,7 @@ jobs:
artifacts-dir: integration-tests/logs

- name: Run Integration Tests
timeout-minutes: 60
run: |
source "$(poetry env info --path)/bin/activate"

Expand Down Expand Up @@ -161,6 +164,7 @@ jobs:
artifacts-dir: graph-tests/logs

- name: Run Graph Tests
timeout-minutes: 60
run: |
source "$(poetry env info --path)/bin/activate"

Expand Down Expand Up @@ -238,6 +242,7 @@ jobs:
cd content
poetry run pip install git+https://github.com/demisto/demisto-sdk@${{ steps.get-commit.outputs.commit }}
- name: Run content unit tests
timeout-minutes: 60
env:
PYTHONPATH: ${{ github.workspace }}/content
run: |
Expand Down Expand Up @@ -281,6 +286,7 @@ jobs:
echo -e "[validate]\nrun_specific_validations=BA101" > .demisto-sdk-conf

- name: run pre-commit on changed files
timeout-minutes: 60
run: |
source $(poetry env info --path)/bin/activate
cd content
Expand All @@ -296,6 +302,7 @@ jobs:
demisto-sdk pre-commit --validate --show-diff-on-failure --verbose

- name: run pre-commit on input files
timeout-minutes: 60
continue-on-error: true
run: |
source $(poetry env info --path)/bin/activate
Expand Down Expand Up @@ -329,6 +336,7 @@ jobs:
path: content

- name: Run Graph
timeout-minutes: 60
run: |
source $(poetry env info --path)/bin/activate
cd content
Expand Down
Loading