-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BA125 validation #4161
BA125 validation #4161
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
a few comments.
...dk/commands/validate/validators/BA_validators/BA125_customer_facing_docs_disallowed_terms.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Minor comments.
...dk/commands/validate/validators/BA_validators/BA125_customer_facing_docs_disallowed_terms.py
Outdated
Show resolved
Hide resolved
...dk/commands/validate/validators/BA_validators/BA125_customer_facing_docs_disallowed_terms.py
Outdated
Show resolved
Hide resolved
…ustomer_facing_docs_disallowed_terms.py Co-authored-by: Yuval Hayun <70104171+YuvHayun@users.noreply.github.com>
…ustomer_facing_docs_disallowed_terms.py Co-authored-by: Yuval Hayun <70104171+YuvHayun@users.noreply.github.com>
Co-authored-by: Yuval Hayun <70104171+YuvHayun@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
Related Issues
fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-9997
Description