Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BA125 validation #4161

Merged
merged 27 commits into from
Jun 2, 2024
Merged

BA125 validation #4161

merged 27 commits into from
Jun 2, 2024

Conversation

yedidyacohenpalo
Copy link
Contributor

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-9997

Description

@yedidyacohenpalo yedidyacohenpalo changed the title new format BA125 validation Apr 16, 2024
Copy link
Contributor

@jbabazadeh jbabazadeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!
a few comments.

Copy link
Contributor

@YuvHayun YuvHayun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Minor comments.

yedidyacohenpalo and others added 2 commits May 29, 2024 14:54
…ustomer_facing_docs_disallowed_terms.py

Co-authored-by: Yuval Hayun <70104171+YuvHayun@users.noreply.github.com>
…ustomer_facing_docs_disallowed_terms.py

Co-authored-by: Yuval Hayun <70104171+YuvHayun@users.noreply.github.com>
yedidyacohenpalo and others added 2 commits May 29, 2024 14:54
Co-authored-by: Yuval Hayun <70104171+YuvHayun@users.noreply.github.com>
Copy link
Contributor

@jbabazadeh jbabazadeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@yedidyacohenpalo yedidyacohenpalo requested review from YuvHayun and removed request for RosenbergYehuda June 2, 2024 08:10
@yedidyacohenpalo yedidyacohenpalo merged commit d2ce3b5 into master Jun 2, 2024
24 of 25 checks passed
@yedidyacohenpalo yedidyacohenpalo deleted the validetion/BA125 branch June 2, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants