Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved removed_integration_parameters to new validations #4354

Merged
merged 6 commits into from
Jun 17, 2024
Merged

Moved removed_integration_parameters to new validations #4354

merged 6 commits into from
Jun 17, 2024

Conversation

jlevypaloalto
Copy link
Contributor

Related Issues

fixes: CIAC-7519

Description

Moves the removed_integration_parameters validation to the new validation

YuvHayun
YuvHayun approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@YuvHayun YuvHayun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

demisto_sdk/commands/validate/sdk_validation_config.toml Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Changelog(s) in markdown:

  • Added the removed_integration_parameter validation to the new validate as NoRemovedIntegrationParametersValidator. #4354

@jlevypaloalto jlevypaloalto merged commit f232b29 into master Jun 17, 2024
25 checks passed
@jlevypaloalto jlevypaloalto deleted the jl-removed_integration_parameters branch June 17, 2024 12:59
@jlevypaloalto jlevypaloalto mentioned this pull request Jun 17, 2024
Merged
@content-bot content-bot mentioned this pull request Jun 18, 2024
Open
@samuelFain samuelFain mentioned this pull request Jun 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuvHayun YuvHayun YuvHayun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jlevypaloalto @YuvHayun