Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Docker image for Devo integration support #462

Merged
merged 1 commit into from
Sep 19, 2019
Merged

Initial Docker image for Devo integration support #462

merged 1 commit into from
Sep 19, 2019

Conversation

bsbvm
Copy link
Contributor

@bsbvm bsbvm commented Sep 16, 2019

Docker image including devodsconnector (https://github.com/DevoInc/python-ds-connector/) and Devo Python SDK (https://github.com/DevoInc/python-sdk) required to support new Devo Demisto integration.

@welcome
Copy link

welcome bot commented Sep 16, 2019

Thanks for opening your first pull request. You are awesome!

Qustions about how we build Docker images? Make sure to checkout our README.

What happens next?

  • CircleCI will run the build cycle on any new/modified docker images. If the build fails make sure to review the CircleCI logs and try to fix any issues.
  • Once the build passes CircleCI will create a development docker image which can be used for local testing. A comment with the details will be posted to this PR.
  • A member of the team will then review the pull request.
  • If all is good and both the build is passing and the pull request has passed review, you will be able to merge the PR.
  • Once merged, CircleCI will run another build and create a production ready docker image which will be deployed at Docker Hub under the demisto organization: https://hub.docker.com/u/demisto .

Good luck to us all!

@CLAassistant
Copy link

CLAassistant commented Sep 18, 2019

CLA assistant check
All committers have signed the CLA.

@glicht
Copy link
Contributor

glicht commented Sep 18, 2019

@bsbvm thanks for the contribution. We require signing a CLA in order to accept the contribution. Please follow instruction in the following comment: #462 (comment)

@bsbvm bsbvm closed this Sep 19, 2019
@bsbvm
Copy link
Contributor Author

bsbvm commented Sep 19, 2019

Fixed commit user

@bsbvm bsbvm reopened this Sep 19, 2019
Copy link
Contributor

@glicht glicht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. Once the build on master completes the image will be available via docker hub.

@glicht glicht merged commit c06757c into demisto:master Sep 19, 2019
@welcome
Copy link

welcome bot commented Sep 19, 2019

Congrats on merging your first pull request! 🎉 How awesome!

@dc-builder
Copy link
Contributor

Docker Image Ready - Production

Docker automatic build at CircleCI has deployed your docker image: demisto/devo:1.0.0.1978
It is available now on docker hub at: https://hub.docker.com/r/demisto/devo/tags
Get started by pulling the image:

docker pull demisto/devo:1.0.0.1978

Docker Metadata

  • Image ID: sha256:f834b365cd718ee568a1118393d6b1ccc006870a720d667f63d5d8c2ac6f931e
  • Created: 2019-09-19T14:13:30.077960661Z
  • Arch: linux/amd64
  • Command: ["python3"]
  • Environment:
    • PATH=/usr/local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
    • LANG=C.UTF-8
    • GPG_KEY=0D96DF4D4110E5C43FBFB17F2D347EA6AA65421D
    • PYTHON_VERSION=3.7.4
    • PYTHON_PIP_VERSION=19.2.3
    • PYTHON_GET_PIP_URL=https://github.com/pypa/get-pip/raw/309a56c5fd94bd1134053a541cb4657a4e47e09d/get-pip.py
    • PYTHON_GET_PIP_SHA256=57e3643ff19f018f8a00dfaa6b7e4620e3c1a7a2171fd218425366ec006b3bfe
  • Labels:
    • org.opencontainers.image.authors:Demisto <containers@demisto.com>
    • org.opencontainers.image.revision:c06757c57bb220747fe99e7ad39ca2593e2528f7
    • org.opencontainers.image.version:1.0.0.1978

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants