Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List.traverseValidationA and List.sequenceValidationA now preserve the order of errors #192

Merged
merged 4 commits into from
Nov 10, 2022

Conversation

ursenzler
Copy link
Contributor

Proposed Changes

Preserve the order of errors when executing List.traverseValidationA - and as a consequence for List.sequenceValidationA.
Fixes Should List.sequenceValidationA preserve order? #191

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Could however be a breaking change because it changes the behaviour!

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Build and tests pass locally
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Further comments

I think this is rather straight forward :-)

Let me know if something needs to be changed. E.g. I didn't format it with Fantomas because other parts of the file would have been changed as well.

Copy link
Collaborator

@TheAngryByrd TheAngryByrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor Change but looks good otherwise.

src/FsToolkit.ErrorHandling/List.fs Outdated Show resolved Hide resolved
@TheAngryByrd
Copy link
Collaborator

TheAngryByrd commented Nov 8, 2022

I didn't format it with Fantomas because other parts of the file would have been changed as well.

That's fine. Go ahead and format it. I'm used to it by now.

@ursenzler
Copy link
Contributor Author

I formatted List.fs with Fantomas, but it's not in an accepted format. I'm a bit lost here.

@TheAngryByrd
Copy link
Collaborator

hmm did you run build.cmd/sh formatcode or did you run it from your editor? I don't know if VS or Rider pickup the dotnet tool correctly, which the FAKE build is using the dotnet-tool.

@ursenzler
Copy link
Contributor Author

ah, I see. I ran it from the editor.

@TheAngryByrd TheAngryByrd merged commit f35a483 into demystifyfp:master Nov 10, 2022
@TheAngryByrd
Copy link
Collaborator

Thank you!

@ursenzler
Copy link
Contributor Author

Thanks for this excellent library!!

TheAngryByrd added a commit that referenced this pull request Nov 18, 2022
- [FSharp.Core version warning](#194). Credits @TheAngryByrd
- [List.traverseValidationA and List.sequenceValidationA now preserve the order of errors](#192). Credits @ursenzler
TheAngryByrd added a commit that referenced this pull request Nov 19, 2022
- [FSharp.Core version warning](#194). Credits @TheAngryByrd
- [List.traverseValidationA and List.sequenceValidationA now preserve the order of errors](#192). Credits @ursenzler
- [Fixing Fable Build](#196) Credits @alfonsogarciacaro
TheAngryByrd added a commit that referenced this pull request Nov 19, 2022
- [FSharp.Core version warning](#194). Credits @TheAngryByrd
- [List.traverseValidationA and List.sequenceValidationA now preserve the order of errors](#192). Credits @ursenzler
- [Fixing Fable Build](#196) Credits @alfonsogarciacaro
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should List.sequenceValidationA preserve order?
2 participants