-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List.traverseValidationA and List.sequenceValidationA now preserve the order of errors #192
Conversation
…e order of errors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor Change but looks good otherwise.
That's fine. Go ahead and format it. I'm used to it by now. |
I formatted List.fs with Fantomas, but it's not in an accepted format. I'm a bit lost here. |
hmm did you run |
ah, I see. I ran it from the editor. |
Thank you! |
Thanks for this excellent library!! |
- [FSharp.Core version warning](#194). Credits @TheAngryByrd - [List.traverseValidationA and List.sequenceValidationA now preserve the order of errors](#192). Credits @ursenzler
- [FSharp.Core version warning](#194). Credits @TheAngryByrd - [List.traverseValidationA and List.sequenceValidationA now preserve the order of errors](#192). Credits @ursenzler - [Fixing Fable Build](#196) Credits @alfonsogarciacaro
- [FSharp.Core version warning](#194). Credits @TheAngryByrd - [List.traverseValidationA and List.sequenceValidationA now preserve the order of errors](#192). Credits @ursenzler - [Fixing Fable Build](#196) Credits @alfonsogarciacaro
Proposed Changes
Preserve the order of errors when executing List.traverseValidationA - and as a consequence for List.sequenceValidationA.
Fixes Should List.sequenceValidationA preserve order? #191
Types of changes
Could however be a breaking change because it changes the behaviour!
Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
I think this is rather straight forward :-)
Let me know if something needs to be changed. E.g. I didn't format it with Fantomas because other parts of the file would have been changed as well.