Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Seq)!: Add sequenceResultA, align sequenceResultM #255

Merged
merged 7 commits into from
Apr 6, 2024
Merged

feat(Seq)!: Add sequenceResultA, align sequenceResultM #255

merged 7 commits into from
Apr 6, 2024

Conversation

bartelink
Copy link
Contributor

@bartelink bartelink commented Feb 15, 2024 •
edited

Implements #254

  • Add Seq.sequenceResultA
  • align signature of sequenceResultM with that of sequenceResultA (yield an Array, rather than accumulating in a list and upcasting via List.toSeq
  • add docs for sequenceResultM
  • remove FSharp.xml content file (noise when searching in Rider)

@bartelink bartelink force-pushed the array-sequence branch 2 times, most recently from 4a13d62 to f23dd0e Compare February 15, 2024 00:14
@bartelink bartelink mentioned this pull request Feb 15, 2024
Closed
@bartelink bartelink changed the title refactor(Seq.sequenceResultM)!: Change Ok to Array feat(Seq)!: Add sequenceResultA, align sequenceResultM Feb 15, 2024
@bartelink
Copy link
Contributor Author

bartelink commented Feb 15, 2024 •
edited

Open to removing anything you consider an overstep - I'm not enjoying the fantomas ruleset so there is some letter of the law interpretations.

Please push back on anything that's not right!

have not actually fsi'd the doc samples, or looked at the gitbook

@bartelink bartelink marked this pull request as ready for review February 15, 2024 01:46
bartelink
bartelink commented Feb 15, 2024
View reviewed changes
paket.dependencies Outdated Show resolved Hide resolved
bartelink
bartelink commented Feb 15, 2024
View reviewed changes
paket.dependencies Outdated Show resolved Hide resolved
TheAngryByrd
TheAngryByrd requested changes Feb 15, 2024
View reviewed changes
Copy link
Collaborator

@TheAngryByrd TheAngryByrd left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ Thanks for this!. Left some feedback.

src/FsToolkit.ErrorHandling/Seq.fs Show resolved Hide resolved
@bartelink
Copy link
Contributor Author

I'd prefer not to make breaking changes here unless you want to retarget for #249

as mentioned in #254 I'm happy either way.

Adding it is not time-sensitive for me, so I'll leave it entirely up to you whether you want
a) this PR based on v5
b) remove this diff and add a PR that can be merged later that does the contract change

I guess my slight preference is to stay with one PR, but I'm a maintainer too so I'd prefer you to make the call.

@bartelink bartelink changed the base branch from master to v5 February 15, 2024 23:20
@bartelink bartelink force-pushed the array-sequence branch 2 times, most recently from 3a5fe58 to d088226 Compare February 15, 2024 23:49
bartelink
bartelink commented Feb 15, 2024
View reviewed changes
build/build.fsproj
@@ -4,10 +4,12 @@
<OutputType>Exe</OutputType>
<TargetFramework>net7.0</TargetFramework>
<IsPackable>false</IsPackable>
<!-- <NoWarn>NU1904</NoWarn>-->
<TreatWarningsAsErrors>false</TreatWarningsAsErrors>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a new vulnerability that breaks the build
I see you have 1903 in the build props - if you fix that, I'l rebase off that as its obv not ideal to have this in the PR

@bartelink
Copy link
Contributor Author

The build wasn't happy for reasons I could not discern - happy to rebase or adjust this any time; just ping
By the same token, if you want to make adjustments and/or just merge it, that's fine too

@TheAngryByrd TheAngryByrd merged commit 4561d77 into demystifyfp:v5 Apr 6, 2024
@bartelink bartelink deleted the array-sequence branch April 6, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheAngryByrd TheAngryByrd TheAngryByrd requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bartelink @TheAngryByrd