Show OS notifications for errors #366
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davewasmer
force-pushed
the
os-error-notifications
branch
2 times, most recently
from
190e97e
to
04b4a14
Compare
davewasmer
force-pushed
the
os-error-notifications
branch
from
04b4a14
to
d72d8da
Compare
|
Actually gonna close this for now. Definitely want this feature, but needs a bit more thought (i.e. CLI integration, comprehensive opt-out, more error path coverage) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #247
Implementation is complete on this PR, but untested, so do not merge until someone can test to confirm.