-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tutorial/docs for visualization #33
Conversation
…onvenience, and also speed up GUI by a factor of 2x by avoiding calling ``draw()`` twice for every slider action (the slider calls ``draw()`` by default).
(this is still work in progress - I'll post a link to a built version on RTD once it's ready for review) |
@ChrisBeaumont - this is ready for review, but readthedocs is acting up (I know it builds with the correct dependencies because it worked once, but it's refusing to build on demand for my fork) so you'll need to build locally to see the new documentation page. Let me know what you think about the plotting API! |
Looks great! This puts the old IDL code to shame :) One minor point: in stead of Also, is this compatible with plotting with APLpy? |
Hmm, that's not a bad idea. In that case, the plotter becomes single purpose (i.e. tree or contour). Maybe I should then make two separate Plotter classes since only the tree one needs the cached positions? Then one would avoid recomputing the cached positions when calling |
The problem with the latter option is then once has e.g. |
You're right, that doesn't feel quite right. The way it is is fine |
Regarding APLpy - I'm planning to try and make it possible to use them together, and will add a section here once I get an example working :) (will open an issue for that) Is this ok to merge? |
👍 |
Add tutorial/docs for visualization
Once #29 is merged, I will work on this.