fix: tree view stub

packages/engine-server/src/drivers/file/storev2.ts

@@ -700,8 +700,11 @@ export class FileStorageV2 implements DStoreV2 {
       notes: this.notes,
       vault: note.vault,
     });
+    // don't count as delete if we're updating existing note
+    let noDelete = false;
     if (maybeNote?.stub || opts?.updateExisting) {
       note = { ...maybeNote, ...note };
+      noDelete = true;
     } else {
       changed = await this._writeNewNote({ note, maybeNote, opts });
     }
@@ -711,7 +714,7 @@ export class FileStorageV2 implements DStoreV2 {
       notePath: note.fname,
       schemaModDict: this.schemas,
     });
-    // order matters - only write file after parents are established
+    // order matters - only write file after parents are established @see(_writeNewNote)
     await note2File({
       note,
       vault: note.vault,
@@ -731,7 +734,7 @@ export class FileStorageV2 implements DStoreV2 {
       status: "update" as const,
     })) as NoteChangeEntry[];
     changedEntries.push({ note, status: "create" });
-    if (maybeNote && !maybeNote.stub) {
+    if (maybeNote && !noDelete) {
       changedEntries.push({ note: maybeNote, status: "delete" });
     }
     return {

packages/engine-server/src/enginev2.ts

@@ -210,18 +210,20 @@ export class DendronEngineV2 implements DEngineV2 {
     let noteNew: NotePropsV2 | undefined = maybeNote;
     let changed: NoteChangeEntry[] = [];
     let error = null;
+    let updateExisting = false;
     if ((!maybeNote || maybeNote.stub) && createIfNew) {
       this.logger.debug({ ctx, maybeNote, msg: "create-new" });
       if (maybeNote?.stub) {
         noteNew = maybeNote;
         delete noteNew.stub;
+        updateExisting = true;
       } else {
         noteNew = NoteUtilsV2.createWithSchema({
           noteOpts: { fname: npath, vault },
           engine: this,
         });
       }
-      changed = (await this.writeNote(noteNew, { newNode: true })).data;
+      changed = (await this.writeNote(noteNew, { updateExisting })).data;
     }
     if (!createIfNew && !maybeNote) {
       error = new DendronError({ status: "no_note_found" });

packages/engine-server/src/topics/markdown/plugins/index.ts

@@ -1,5 +1,4 @@
 export * from "./dendronLinksPlugin";
 export * from "./replaceRefs";
 export * from "./dendronNoteRefPlugin";
-export * from "./enrichNode";
 export * from "./types";

packages/plugin-core/src/commands/GotoNote.ts

@@ -51,23 +51,30 @@ export class GotoNoteCommand extends BasicCommand<CommandOpts, CommandOutput> {
     let pos: undefined | Position;
     if (opts.mode === "note") {
       const client = DendronWorkspace.instance().getEngine();
-      const { data } = await client.getNoteByPath({
-        npath: qs,
-        createIfNew: true,
-        vault,
-      });
-      const note = data?.note as NotePropsV2;
-      const npath = NoteUtilsV2.getPathV4({ note, wsRoot: DendronWorkspace.wsRoot() });
-      const uri = Uri.file(npath);
-      const editor = await VSCodeUtils.openFileInEditor(uri);
-      this.L.info({ ctx, opts, msg: "exit" });
-      if (opts.anchor && editor) {
-        const text = editor.document.getText();
-        const pos = findHeaderPos({ anchor: opts.anchor.value, text });
-        editor.selection = new Selection(pos, pos);
-        editor.revealRange(editor.selection);
-      }
-      return { note, pos };
+      return DendronWorkspace.instance().pauseWatchers<CommandOutput>(
+        async () => {
+          const { data } = await client.getNoteByPath({
+            npath: qs,
+            createIfNew: true,
+            vault,
+          });
+          const note = data?.note as NotePropsV2;
+          const npath = NoteUtilsV2.getPathV4({
+            note,
+            wsRoot: DendronWorkspace.wsRoot(),
+          });
+          const uri = Uri.file(npath);
+          const editor = await VSCodeUtils.openFileInEditor(uri);
+          this.L.info({ ctx, opts, msg: "exit" });
+          if (opts.anchor && editor) {
+            const text = editor.document.getText();
+            const pos = findHeaderPos({ anchor: opts.anchor.value, text });
+            editor.selection = new Selection(pos, pos);
+            editor.revealRange(editor.selection);
+          }
+          return { note, pos };
+        }
+      );
     } else {
       throw new DendronError({ msg: "goto schema not implemented" });
     }