Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(workspace): autocomplete for usertags and hashtags #3610

Merged
merged 2 commits into from
Sep 30, 2022

Conversation

Harshita-mindfire
Copy link
Contributor

This PR aims to fix the ongoing issue with usertags and hashtags autocomplete after first . (eg: #kind. , @johndoe. won't show autocomplete suggestions)

  • removed # from MARKDOWN_WORD_PATTERN to display autocomplete for tags

Dendron Extended PR Checklist

  • NOTE: the links don't work. you'll need to go into the wiki and use lookup to find the note until we fix some issues in the markdown export

Code

Basics

Extended

  • General
    • check whether code be simplified
    • check if similar function already exist in the codebase. if so, can it be re-used?
    • check if this change adversely impact performance
  • Operations
    • when shipping this change, will it just work or will it introduce additional operational overhead due to complicated interface or known bugs?
  • Architecture
    • check if code is introducing changes on a foundational class or interface. if so, call for design review if needed

Instrumentation

Basics

  • [~] if you are adding analytics related changes, make sure the Telemetry docs are updated

Extended

Tests

Basics

Extended

Docs

  • [~] if your change reflects documentation changes, also submit a PR to dendron-site and mention the doc PR link in your current PR
  • [~] does this change introduce a new or better way of doing things that others need to be aware of? if so, an async should be created and a process added in Development or Packages

Close the Loop

Extended

  • [~] is this a developer BREAKING change? if another person cloning from this branch will need to adjust their dependencies or mental model of the architecture, then it is. if this is the case, make sure this is communicated according to Close Loop

@Harshita-mindfire Harshita-mindfire marked this pull request as ready for review September 29, 2022 17:44
@auto-assign auto-assign bot requested review from namjul and tma66 September 29, 2022 17:44
@Harshita-mindfire Harshita-mindfire merged commit d25b6bb into master Sep 30, 2022
@Harshita-mindfire Harshita-mindfire deleted the fix/tags-autocomplete branch September 30, 2022 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants