Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(publish): Table of Contents is missing user tags, inline code, dashes and underlines #2465

Merged
merged 1 commit into from Feb 22, 2022

Conversation

SeriousBug
Copy link
Contributor

#2456

The cache files need to be deleted for this fix to apply, otherwise the cached bad version will be published.

Screenshot_20220222_031635

See ToC on the image above

Dendron Extended PR Checklist

Code

Basics

Extended

  • General
    • check whether code be simplified
    • check if similar function already exist in the codebase. if so, can it be re-used?
    • check if this change adversely impact performance
  • Operations
    • when shipping this change, will it just work or will it introduce additional operational overhead due to complicated interface or known bugs?
  • Architecture
    • [~] check if code is introducing changes on a foundational class or interface. if so, call for design review if needed

Instrumentation

Basics

  • [~] if you are adding analytics related changes, make sure the Telemetry docs are updated

Extended

Tests

Basics

Extended

  • If you are adding a new language feature (graphically visible in VS Code/preview/publishing), an example is included in the test workspace

  • CSS

    • [~] display is correct for following dimensions
      • sm: screen ≥ 576px, eg. iphonex, (375x812)
      • lg: screen ≥ 992px
      • xxl: screen ≥ 1600px eg. mac (1600x900)
    • [~] display is correct for following browsers (across the various dimensions)
      • safari
      • firefox
      • chrome

Docs

Basics

  • [~] if your change reflects documentation changes, also submit a PR to dendron-site and mention the doc PR link in your current PR

Basics

  • [~] does this change introduce a new or better way of doing things that others need to be aware of? if so, an async should be created and a process added in Development or Packages

Close the Loop

Basics

Extended

  • [~] is this a developer BREAKING change? if another person cloning from this branch will need to adjust their dependencies or mental model of the architecture, then it is. if this is the case, make sure this is communicated according to Close Loop

@kevinslin kevinslin merged commit 79c6d9e into master Feb 22, 2022
@kevinslin kevinslin deleted the fix/bad-toc-naming branch February 22, 2022 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants