Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(common): don't reload workspace when running doctor airtable command #2620

Merged
merged 3 commits into from
Mar 25, 2022

Conversation

kevinslin
Copy link
Member

@kevinslin kevinslin commented Mar 23, 2022

enhance(common): don't reload workspace when running doctor airtable command

Doctor doesn't need to reload the workspace when fixing airtable ids. This makes sure that it doesn't.
Also fixes a race condition from not awaiting the output of engine.write


This introduces a new recipe: [[Adding a new doctor command|dendron://dendron.docs/pkg.plugin-core.dev.cook#adding-a-new-doctor-command]]


Dendron Extended PR Checklist

Code

Basics

Extended

  • General
    • check whether code be simplified
    • check if similar function already exist in the codebase. if so, can it be re-used?
    • check if this change adversely impact performance
  • Opexations
    • when shipping this change, will it just work or will it introduce additional operational overhead due to complicated interface or known bugs?
  • Arcxitecture
    • check if code is introducing changes on a foundational class or interface. if so, call for design review if needed

Instrumentation

NA

Tests

Basics

Extended

NA

Docs

Basics

  • [~] if your change reflects documentation changes, also submit a PR to dendron-site and mention the doc PR link in your current PR

Basics

  • does this change introduce a new or better way of doing things that others need to be aware of? if so, an async should be created and a process added in Development or Packages

Close the Loop

Basics

Extended

  • [~] is this a developer BREAKING change? if another person cloning from this branch will need to adjust their dependencies or mental model of the architecture, then it is. if this is the case, make sure this is communicated according to Close Loop

@kevinslin kevinslin changed the title fix enhance(common): don't reload workspace when running doctor airtable command Mar 24, 2022
@kevinslin kevinslin marked this pull request as ready for review March 24, 2022 15:41
Copy link
Contributor

@hikchoi hikchoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I thought about adding a property to the DoctorActionsEnum themselves when I fixed this issue for FIND_INCOMPATIBLE_EXTENSIONS, but I didn't realize that other actions also didn't really need a relead 😅

@kevinslin kevinslin merged commit 34d0f4b into master Mar 25, 2022
@kevinslin kevinslin deleted the chore/doctor branch March 25, 2022 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants