This repository has been archived by the owner on Dec 7, 2019. It is now read-only.
Домашнее задание 5 #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -18,10 +18,10 @@ class FileButton extends React.Component { | |||
| reader.onload = function() { | |||
| if (file.type.startsWith("image/")) { | |||
| text = reader.result; | |||
| this_ptr.props.updateData("", getTime(), text); | |||
| this_ptr.props.updateData(this_ptr.props.id + 1, "", text); | |||
There was a problem hiding this comment.
Такс, а этот this_ptr я пропустил. Так делать неправильно, ведь, в js есть методы для проброса контекста bind, apply, call и еще есть arrow functions, где контекст не меняется вовсе. Это надо исправить
| } | ||
|
|
||
| cleanValue() { | ||
| this.refs.textMessageForm.value = ""; |
There was a problem hiding this comment.
Тоже что-то странное. Данными полей надо оперировать через state
martinkomitsky
suggested changes
Dec 6, 2018
|
|
||
| var files = event.target.files; | ||
|
|
||
| for (var i = 0; i < files.length; i++) { |
There was a problem hiding this comment.
Использовать перечисляющий метод forEach(val, ind) => {...}
|
|
||
| for (var i = 0; i < files.length; i++) { | ||
| // eslint-disable-next-line no-loop-func | ||
| (function(file) { |
There was a problem hiding this comment.
Вынести в нормальную функцию и избавиться от IIFE
| } | ||
|
|
||
| updateDataMessageForm(text) { | ||
| this.setState({ text: text }); |
martinkomitsky
approved these changes
Dec 6, 2018
|
5 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Переделал проект на React. Осталась только проблема с overflow-y, то есть у MessageList не совсем корректно CSS работает. Буду рад, если подскажешь как исправить)