Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve temp files management #37

Closed
3 tasks done
dennisangemi opened this issue Jul 20, 2023 · 0 comments
Closed
3 tasks done

Improve temp files management #37

dennisangemi opened this issue Jul 20, 2023 · 0 comments
Labels
Critical enhancement New feature or request
Milestone

Comments

@dennisangemi
Copy link
Owner

dennisangemi commented Jul 20, 2023

Summary

Attualmente, se il datapackage è yaml viene convertito in json e viene chiamato datapackage.json. Questo potrebbe creare non pochi problemi perché

  1. Potrebbe già esistere un datapackage.json che contiene valori diversi dal yaml
  2. Rischieremmo di eliminare un file non temporaneo. Alla fine dello script, se il formato originario era yaml, viene cancellato datapackage.json (senza effettuare alcun check)

Actions

  • check if datapackage.json exists before creating it
  • If it exists, create a temp file with a different name (how?) working_datapackage="frct-temp-dp.json"
  • Edit cleaning section at the end of the script
@dennisangemi dennisangemi added enhancement New feature or request Critical labels Jul 20, 2023
@dennisangemi dennisangemi added this to the v1.0 milestone Jul 20, 2023
dennisangemi added a commit that referenced this issue Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Critical enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant