Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix the issue where getters are not updated after state has been updated #95

Merged

Conversation

prakhar-pal
Copy link

No description provided.

@dennybiasiolli
Copy link
Owner

Great catch, thanks!

@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2022

Codecov Report

Merging #95 (55cd3f8) into master (b84e967) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #95   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines           64        64           
  Branches        23        25    +2     
=========================================
  Hits            64        64           
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/components/connect.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b84e967...55cd3f8. Read the comment docs.

@coveralls
Copy link

coveralls commented Mar 20, 2022

Pull Request Test Coverage Report for Build 2012877291

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 2012567945: 0.0%
Covered Lines: 51
Relevant Lines: 51

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2012877291

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 2012567945: 0.0%
Covered Lines: 51
Relevant Lines: 51

💛 - Coveralls

@dennybiasiolli dennybiasiolli merged commit ba2c50a into dennybiasiolli:master Mar 20, 2022
@dennybiasiolli
Copy link
Owner

I will release this fix tomorrow, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants