Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Authentication Method Mismatch #137

Merged
merged 3 commits into from
Nov 25, 2022

Conversation

shiyuhang0
Copy link
Contributor

@shiyuhang0 shiyuhang0 commented Nov 25, 2022

#113

This pr supports the Authentication Method Mismatch described as https://dev.mysql.com/doc/dev/mysql-server/latest/page_protocol_connection_phase.html

@shiyuhang0
Copy link
Contributor Author

shiyuhang0 commented Nov 25, 2022

@lideming PTAL
But I don't know how to test it. I test it locally by TiDB Cloud Serverless Tier which always trigger the auth method mismacth phase.
But it requires TLS, so I mixed this pr https://github.com/denodrivers/mysql/compare/master...codeflows:tls?expand=1 to test it locally and successfully queried the Serverless Tier.

@lideming
Copy link
Collaborator

Please run deno fmt to make CI pass.

@shiyuhang0
Copy link
Contributor Author

I found the test failed with the latest MariaDB. If it is my fault, please let me known

@lideming
Copy link
Collaborator

Not your fault. It failed on the master branch too. Seems that something changed about the EOF packet in the latest mariadb... I think we can temporarily disable mariadb:latest and see if other tests pass:
https://github.com/lideming/deno_mysql/blob/master/.github/workflows/ci.yml#L35

@lideming
Copy link
Collaborator

LGTM. Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants