Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Behaviour of --reload #1044

Closed
kitsonk opened this issue Oct 20, 2018 · 4 comments
Closed

Behaviour of --reload #1044

kitsonk opened this issue Oct 20, 2018 · 4 comments

Comments

@kitsonk
Copy link
Contributor

kitsonk commented Oct 20, 2018

Currently, the --reload flag does not invalidate the transpiled versions of any local modules. It only causes cached versions of non-local modules to be invalidated, which of course in turn invalidates their local transpiled versions.

While it might be unlikely, there is still a valid scenario where a user will make a change in another module that impacts the types that are available to a local module that is already transpiled, but is not caught by the compiler because it skips transpilation.

It feels to me it is less surprising that --reload would also invalidate any local modules that are transpiled, irrespective of if their source has changed.

@bartlomieju
Copy link
Member

@kitsonk is this issue still relevant?

@kitsonk
Copy link
Contributor Author

kitsonk commented Feb 12, 2019

I believe it is.

@ry
Copy link
Member

ry commented Feb 12, 2019

We should just combine --reload and --recompile ... it's more browser-like and simpler.

@kitsonk
Copy link
Contributor Author

kitsonk commented Feb 12, 2019

That would work for me... Related to #1582

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants