Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--no-check affects runtime behavior #11437

Closed
wojpawlik opened this issue Jul 18, 2021 · 2 comments
Closed

--no-check affects runtime behavior #11437

wojpawlik opened this issue Jul 18, 2021 · 2 comments
Labels
bug Something isn't working correctly fix available there is a fix available in a third party library that needs to be merged swc related to swc (bundling/transpiling) upstream Changes in upstream are required to solve these issues

Comments

@wojpawlik
Copy link 

import XR from "https://cdn.skypack.dev/xregexp@5.0.2?dts";

const version = XR.tag("xn")`
  .+?
`;

console.log(version);

Without --no-check, correctly outputs /.+?/.
With --no-check, incorrectly outputs /\n(?:).+?\n/.

deno 1.12.0+1ad6575 (canary, x86_64-pc-windows-msvc)

Based on actual code: https://github.com/wojpawlik/deno2node/blob/d224750108fcdc70d666b3cc3f9e95e6310a4a47/src/_transformations/specifiers.ts#L5-L8.

Blocks #11340.
@satyarohith satyarohith added bug Something isn't working correctly swc related to swc (bundling/transpiling) labels Jul 18, 2021
@kitsonk
Copy link
Contributor

kitsonk commented Jul 19, 2021

Upstream issue is: swc-project/swc#1791

wojpawlik added a commit to fromdeno/deno2node that referenced this issue Jul 19, 2021
@wojpawlik
Work around denoland/deno#11437
5b4f96f
@kitsonk kitsonk added upstream Changes in upstream are required to solve these issues fix available there is a fix available in a third party library that needs to be merged labels Jul 20, 2021
@bartlomieju
Copy link
Member

Fixed in #11626

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working correctly fix available there is a fix available in a third party library that needs to be merged swc related to swc (bundling/transpiling) upstream Changes in upstream are required to solve these issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kitsonk @bartlomieju @wojpawlik @satyarohith