Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add requesting API name to permission prompt #15936

Merged
merged 20 commits into from Sep 27, 2022

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Sep 17, 2022

Blocked on #15907

Adds information which API requested certain permission.

runtime/js/40_spawn.js Outdated Show resolved Hide resolved
@bartlomieju bartlomieju changed the title [WIP] feat: Add requesting API name to permission prompt feat: Add requesting API name to permission prompt Sep 26, 2022
@bartlomieju
Copy link
Member Author

I think this is good to go for now. I still need to add these hints to FFI APIs, but I'd prefer to do that in a separate PR.

Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

runtime/js/40_spawn.js Outdated Show resolved Hide resolved
runtime/js/40_process.js Outdated Show resolved Hide resolved
ext/net/ops.rs Outdated Show resolved Hide resolved
ext/net/ops.rs Outdated Show resolved Hide resolved
bartlomieju and others added 4 commits September 27, 2022 21:54
Co-authored-by: Leo Kettmeir <crowlkats@toaxl.com>
Co-authored-by: Leo Kettmeir <crowlkats@toaxl.com>
Co-authored-by: Leo Kettmeir <crowlkats@toaxl.com>
Co-authored-by: Leo Kettmeir <crowlkats@toaxl.com>
Copy link
Member

@crowlKats crowlKats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit 212b7dd into denoland:main Sep 27, 2022
@bartlomieju bartlomieju deleted the permission_prompt_api_name branch September 27, 2022 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants