Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Refresh interactive permission prompt #15907

Merged
merged 12 commits into from Sep 22, 2022
Merged

feat: Refresh interactive permission prompt #15907

merged 12 commits into from Sep 22, 2022

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Sep 14, 2022 •
edited

Screen.Recording.2022-09-16.at.19.11.39.mov

@bartlomieju bartlomieju changed the title [WIP] feat: Refresh interactive permission prompt feat: Refresh interactive permission prompt Sep 16, 2022
@bartlomieju bartlomieju added this to the 1.26 milestone Sep 17, 2022
bartlomieju
bartlomieju commented Sep 17, 2022
View reviewed changes
runtime/permissions.rs Outdated Show resolved Hide resolved
runtime/permissions.rs Outdated Show resolved Hide resolved
@bartlomieju bartlomieju mentioned this pull request Sep 17, 2022
Merged
dsherret
dsherret approved these changes Sep 19, 2022
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

runtime/permissions.rs Outdated Show resolved Hide resolved
runtime/permissions.rs Outdated Show resolved Hide resolved
ry
ry approved these changes Sep 21, 2022
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - nice work

@bartlomieju bartlomieju merged commit b20431c into denoland:main Sep 22, 2022
@bartlomieju bartlomieju deleted the permission_prompt_fun branch September 22, 2022 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

@dsherret dsherret dsherret approved these changes

@kitsonk kitsonk Awaiting requested review from kitsonk

@lucacasonato lucacasonato Awaiting requested review from lucacasonato

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.26
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bartlomieju @ry @dsherret