Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Qwik City (create-qwik) #20611

Closed
birkskyum opened this issue Sep 21, 2023 · 0 comments · Fixed by #20892 or #21026
Closed

Support Qwik City (create-qwik) #20611

birkskyum opened this issue Sep 21, 2023 · 0 comments · Fixed by #20892 or #21026
Assignees
Labels
bug Something isn't working correctly node compat

Comments

@birkskyum
Copy link
Contributor

Qwik - Qwik City - GitHub

Platform

Darwin 22.6.0 arm64 arm

Version

deno 1.37.0

Repro

  • deno run -A npm:create-qwik

Expected

      ............
    .::: :--------:.
   .::::  .:-------:.
  .:::::.   .:-------.
  ::::::.     .:------.
 ::::::.        :-----:
 ::::::.       .:-----.
  :::::::.     .-----.
   ::::::::..   ---:.
    .:::::::::. :-:.
     ..::::::::::::
             ...::::Let's create a  Qwik App(v1.2.12)
│
◆  Where would you like to create your new project? (Use '.' or './' for current directory)./qwik-app

Actual

      ............
    .::: :--------:.
   .::::  .:-------:.
  .:::::.   .:-------.
  ::::::.     .:------.
 ::::::.        :-----:
 ::::::.       .:-----.
  :::::::.     .-----.
   ::::::::..   ---:.
    .:::::::::. :-:.
     ..::::::::::::
             ...::::Let's create a  Qwik App(v1.2.12)Not implemented: net.Socket.prototype.constructor with fd option
@birkskyum birkskyum changed the title Support Qwik (create-qwik) Support Qwik City (create-qwik) Sep 21, 2023
@bartlomieju bartlomieju added bug Something isn't working correctly node compat labels Sep 22, 2023
@littledivy littledivy self-assigned this Oct 9, 2023
This was referenced Oct 9, 2023
littledivy added a commit that referenced this issue Oct 30, 2023
Fixes #21012
Closes #20855
Fixes #20890
Fixes #20611
Fixes #20336
Fixes `create-svelte` from #17248

Fixes more reports here:
- #6529 (comment)
- #6529 (comment)
- #6529 (comment)
bartlomieju pushed a commit to bartlomieju/deno that referenced this issue Oct 30, 2023
@littledivy littledivy reopened this Oct 31, 2023
littledivy added a commit that referenced this issue Oct 31, 2023
Workaround the circular references issue by using a initializer function
to give tty stream class to `initStdin`.

Fixes #21024
Fixes #20611
Fixes #20890
Fixes #20336

`create-svelte` works now:
```
divy@mini /t/a> ~/gh/deno/target/debug/deno run -A --unstable --reload npm:create-svelte@latest sveltekit-deno

create-svelte version 5.1.1

┌  Welcome to SvelteKit!
│
◇  Which Svelte app template?
│  Skeleton project
│
◇  Add type checking with TypeScript?
│  Yes, using JavaScript with JSDoc comments
│
◇  Select additional options (use arrow keys/space bar)
│  none
│
└  Your project is ready!

✔ Type-checked JavaScript
  https://www.typescriptlang.org/tsconfig#checkJs

Install community-maintained integrations:
  https://github.com/svelte-add/svelte-add

Next steps:
  1: cd sveltekit-deno
  2: npm install
  3: git init && git add -A && git commit -m "Initial commit" (optional)
  4: npm run dev -- --open

To close the dev server, hit Ctrl-C

Stuck? Visit us at https://svelte.dev/chat
```

---------

Signed-off-by: Divy Srivastava <dj.srivastava23@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working correctly node compat
Projects
None yet
3 participants