Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

suggestion: rename Deno.ConnectTlsOptions.{certChain,privateKey} #22197

Closed
iuioiua opened this issue Jan 31, 2024 · 1 comment
Closed

suggestion: rename Deno.ConnectTlsOptions.{certChain,privateKey} #22197

iuioiua opened this issue Jan 31, 2024 · 1 comment

Comments

@iuioiua
Copy link
Collaborator

iuioiua commented Jan 31, 2024 •
edited

Deno.ListenTlsOptions and Deno.ServeTlsOptions use the cert and key properties; IIUC, these are the same things. If that's correct, I suggest we use the same option names, cert and key for consistency.
@iuioiua iuioiua mentioned this issue Feb 5, 2024
Merged
mmastrac pushed a commit that referenced this issue Feb 18, 2024
@iuioiua
feat: Deno.ConnectTlsOptions.{cert,key} (#22274)
9a43a2b 
Towards #22197
@iuioiua
Copy link
Collaborator Author

iuioiua commented Mar 6, 2024

Completed in #22274

@iuioiua iuioiua closed this as completed Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@iuioiua