Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support NX (running npm:nx) #22966

Closed
birkskyum opened this issue Mar 17, 2024 · 3 comments
Closed

Support NX (running npm:nx) #22966

birkskyum opened this issue Mar 17, 2024 · 3 comments
Labels
bug Something isn't working correctly node API polyfill Related to various "node:*" modules APIs node compat

Comments

@birkskyum
Copy link
Contributor

Version: deno 1.41.3+9c5ddf7

Platform

macos sonoma arm64 arm

Repro

make new project with deno

➜ deno run -A npm:create-nx-workspace

NX Let's create a new workspace [https://nx.dev/getting-started/intro]

✔ Where would you like to create your workspace? · myorg2
✔ Which stack do you want to use? · none
✔ Package-based monorepo, integrated monorepo, or standalone project? · package-based
✔ Enable distributed caching to make your CI faster · No

try to run it:

 deno run -A npm:nx

 NX   Cannot read properties of undefined (reading 'unref')
@bartlomieju
Copy link
Member

Looks like the same problem as #16753 (comment)

@bartlomieju bartlomieju added bug Something isn't working correctly node compat node API polyfill Related to various "node:*" modules APIs labels Mar 21, 2024
@nathanwhit
Copy link
Member

It looks like this was fixed at some point, trying locally on 2.0.0-rc.2, nx now seems to run without issue.

@birkskyum
Copy link
Contributor Author

That's pretty cool! I guess it's a bit of a minute detail, and not really a change required in this repo either, to have the create-nx-workspace detect and use deno install instead of npm install, like it does for some other package managers. Probably easier to fix such details after deno 2 is out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working correctly node API polyfill Related to various "node:*" modules APIs node compat
Projects
None yet
Development

No branches or pull requests

3 participants