We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
// mod.ts export class SortedArray { constructor( array: number[] = [], comparator: (a: number, b: number) => number, ) { } }
then run deno publish --dry-run
deno publish --dry-run
happens on methods, too. not on normal functions, though. type of the args doesn't matter much, just the fact that there is a default initializer
the package publishes without errors
errors out with:
error: Failed ensuring public API type output is valid. TS1016 [ERROR]: A required parameter cannot follow an optional parameter. constructor(array?: number[], comparator: (a: number, b: number) => number){} ~~~~~~~~~~ at file:///Users/teidesu/repo/jsr/some-repro/baz/mod.ts:4:7 You may have discovered a bug in Deno. Please open an issue at: https://github.com/denoland/deno/issues/
deno 1.42.2 (release, aarch64-apple-darwin) v8 12.3.219.9 typescript 5.4.3
The text was updated successfully, but these errors were encountered:
fix(publish): do not error for param with initializer before required…
76df7d7
… parameter (#23356) * denoland/deno_graph#440 Closes #23331
8324921
2e8c441
… parameter (denoland#23356) * denoland/deno_graph#440 Closes denoland#23331
dsherret
Successfully merging a pull request may close this issue.
mcve
then run
deno publish --dry-run
happens on methods, too. not on normal functions, though.
type of the args doesn't matter much, just the fact that there is a default initializer
expected behaviour
the package publishes without errors
actual behaviour
errors out with:
version
The text was updated successfully, but these errors were encountered: