Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ext/node: net.BlockList needs to be implemented for dd-trace #24059

Closed
Tracked by #23744
satyarohith opened this issue May 31, 2024 · 0 comments · Fixed by #24229
Closed
Tracked by #23744

ext/node: net.BlockList needs to be implemented for dd-trace #24059

satyarohith opened this issue May 31, 2024 · 0 comments · Fixed by #24229
Labels
bug Something isn't working correctly node API polyfill Related to various "node:*" modules APIs node compat

Comments

@satyarohith
Copy link
Member

satyarohith commented May 31, 2024

Version: Deno 1.44.0

dd-trace error

DENO_FUTURE=1 deno run -A server.js 
error: Uncaught TypeError: BlockList is not a constructor
    at Object.<anonymous> (file:///Users/sr/p/trace-examples/javascript/node/microservices/user/node_modules/dd-trace/packages/dd-trace/src/plugins/util/ip_extractor.js:32:26)
    at Object.<anonymous> (file:///Users/sr/p/trace-examples/javascript/node/microservices/user/node_modules/dd-trace/packages/dd-trace/src/plugins/util/ip_extractor.js:97:4)
    at Module._compile (node:module:659:34)
    at Object.Module._extensions..js (node:module:673:10)
    at Module.load (node:module:597:32)
    at Function.Module._load (node:module:484:12)
    at Module.require (node:module:609:19)
    at Module.Hook.Module.require (file:///Users/sr/p/trace-examples/javascript/node/microservices/user/node_modules/dd-trace/packages/dd-trace/src/ritm.js:85:33)
    at require (node:module:715:16)
    at Object.<anonymous> (file:///Users/sr/p/trace-examples/javascript/node/microservices/user/node_modules/dd-trace/packages/dd-trace/src/plugins/util/web.js:11:23)

API: https://nodejs.org/api/net.html#class-netblocklist

Ref #23744

@bartlomieju bartlomieju added bug Something isn't working correctly node API polyfill Related to various "node:*" modules APIs labels May 31, 2024
@iuioiua iuioiua self-assigned this Jun 16, 2024
@iuioiua iuioiua removed their assignment Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working correctly node API polyfill Related to various "node:*" modules APIs node compat
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants