Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deno fmt should respect prettierrc and prettierignore did't land #3410

Closed
axetroy opened this issue Nov 27, 2019 · 0 comments · Fixed by #3415
Closed

deno fmt should respect prettierrc and prettierignore did't land #3410

axetroy opened this issue Nov 27, 2019 · 0 comments · Fixed by #3415

Comments

@axetroy
Copy link
Contributor

axetroy commented Nov 27, 2019

Release Note:

fix: deno fmt should respect prettierrc and prettierignore (#3346)

Because flags.rs still using v0.23.0

deno/cli/flags.rs

Lines 14 to 18 in 2cd22b5

macro_rules! std_url {
($x:expr) => {
concat!("https://deno.land/std@v0.23.0/", $x)
};
}

and see the source code: https://deno.land/std@v0.23.0/prettier/main.ts

Here's a question:

how to synchronize deno and deno_std versions

Move discussion to #3320

@axetroy axetroy changed the title deno fmt should respect prettierrc and prettierignore did't land deno fmt should respect prettierrc and prettierignore did't land Nov 28, 2019
@ry ry closed this as completed in #3415 Nov 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant