std/http throws on large chunked responses

[sholladay]

The chunked response handling in std/http seems to be very broken. When you give it a Reader, it's supposed to send a chunked response, but it throws an error after only a few megabytes of data.

Below is a script to reproduce this. If image.jpg is very small, it'll work fine. Interestingly, the amount of data that actually gets sent to the client seems to be somewhat erratic. Sometimes I get ~4 megabytes, sometimes I get < 2 megabytes. Maybe backpressure isn't working properly?

import * as http from 'https://deno.land/std@v0.56.0/http/server.ts';

const respond = async (request: http.ServerRequest) => {
    const file = await Deno.open('./image.jpg');
    await request.respond({
        body   : file,  // works if file is very small, but throws an error if it's a bit large (>4MB ???)
        status : 200
    });
    file.close();
};

for await (const request of http.serve({ port : 3000 })) {
    respond(request);
}

Stack trace

error: Uncaught Error: Short write
      this.err = new Error("Short write");
                 ^
    at BufWriter.checkBytesWritten (https://deno.land/std@v0.56.0/io/bufio.ts:436:18)
    at BufWriter.flush (https://deno.land/std@v0.56.0/io/bufio.ts:487:10)
    at async BufWriter.write (https://deno.land/std@v0.56.0/io/bufio.ts:518:9)
    at async writeChunkedBody (https://deno.land/std@v0.56.0/http/_io.ts:171:5)
    at async writeResponse (https://deno.land/std@v0.56.0/http/_io.ts:267:5)
    at async ServerRequest.respond (https://deno.land/std@v0.56.0/http/server.ts:88:7)
    at async respond (file:///Users/sholladay/Code/personal/pogo/server.ts:5:5)

Environment

OS: macOS 10.14.6

$ deno --version
deno 1.0.2
v8 8.4.300
typescript 3.9.2

I am also able to reproduce this on Deno 1.0.5.

[marcosc90]

Can you try updating to 1.1.0?

Can't reproduce on Can reproduce after spamming multiple requests on:

Ubuntu 20.04
deno 1.1.0
v8 8.4.300
typescript 3.9.2

I'm working on a fix