Deno.Process close()/status()/kill()

[aricart]

Deno.Process probably needs a bit more documentation:

• if close() is called, status() will throw an exception with a bad resource id.
• kill() followed by a status() works fine
• I would expect status() to always work regardless of how the process was terminated.

I would have expected status() to resolve its promise regardless of how the Process is closed/kill or otherwise.

My use of Deno.run() is running a server that I can use for tests. So this creates interesting because if things don't close properly, the tests will fail with resource leaks (love that).

[caseyhoward]

I was also wondering what close() did since there is no documentation. I want to kill a process after a specified timeout. Do I use close() or kill()?

I just tried close() and it appears to do nothing so I tried kill() which works but then I can see terminal input after the process exits and I have to run reset.

[ry]

Close releases Deno’s memory associated with the process. So the subprocess will continue to run. Kill actually sends a signal to the subprocess.

[aricart]

@ry one thing with close is that it doesn't address closing any of the file descriptors - for example, on some utility code I have I had to:

  async stop(): Promise<void> {
    if (!this.stopped) {
      this.stopped = true;
      this.process.stderr?.close();
      this.process.kill(Deno.Signal.SIGKILL);
      this.process.close();
    }
    await this.done;
  }

The unexpected thing is that stderr had to be closed specifically - even though the close - which is owning it is getting called.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[martin-braun]

Close releases Deno’s memory associated with the process. So the subprocess will continue to run. Kill actually sends a signal to the subprocess.

Thanks for the explanation. Is using close() mandatory, though? Shouldn't Deno release memory associated with the process on the end of the scope, automatically?