New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin not initialized when compiling in Deno 1.7 #9257
Comments
This comment has been minimized.
This comment has been minimized.
In this case, I'm using webview. At most it's a combo of webview and abc. Although, I do have something coming down the pipeline for SQLite. But those would be my biggies for the foreseeable. It compiles and runs fine in 1.6 (as long as I'm not attempting to change cache location), but it gives me that error with 1.7, everything else being the same. |
Putting 1.6 aside, does this happen in 1.7 without changing the cache location? |
Yes. |
Okay, please adjust the title and description of this issue to give less detail about that red herring and more about the error that you're seeing in 1.7 irrespective of DENO_DIR. Is "plugin must be initialized" a panic or what? |
That I couldn't tell you if it was a panic or not. All I know that it works in 1.6, but it throws that error in 1.7. If everything else is equal. |
Show the error exactly as it appears. |
That's all that it give back. Deno run its fine, it just when I go to compile and then run the compiled binary. |
I assume this is a SWC bug with ordering of statements in the compiled bundle. We have a swc_bundler upgrade coming up, that might fix this. Lets hold this for 1.7.1 (should release some time this week). |
I did try the canary build and got Don't know if that would have been fixed when a point release came out or not, but thought I would mention it. |
Yep, same error on 1.7.1 as I mentioned from 2 days ago using the official 1.7.1 release today. |
Can confirm, getting the exact same error on 1.7.1 mentioned there #9257 (comment), I'm running Windows 20H2 Using the webview plugin too. |
Same error on 1.7.1 on MacOS: |
Just for reference the following code:
When compiled and ran returns
with
running normally encounters no issues. |
Still getting this with Deno 1.7.2 + webview 0.5.6, on Windows 10 20H2
|
Same here. |
No change |
+1 same here on 1.7.5
After compile on 1.7.5 |
The program appears to now compile, at least with Webview 0.5.3. |
With Deno 1.7.5 and webview_deno 0.5.6 the following occurs:
With webview_deno 0.5.3 (Was testing report from @wwderw) the following occurs:
I don't know when that changed or if I never noticed it. I'm still on Linux (Pop_OS! 20.04) so it might be that it's fixed on windows but not Linux IDK. |
I'm on Linux, Ubuntu Studio beta 21.04, but I am using Deno 1.8, try the latest. It looks like you were still trying with 1.7.5 Deno. |
Can confirm it now works on Deno 1.8. |
I swear I did try updateing before posting my last comment.
Same web-views as before but on Deno1.8.0 Seems like something weird is happening with 0.5.6 downloading something every run but it does work. I'm going to try cross-compiling for windows real quick. |
Cross-compile from Linux to Windows works for webview_deno 0.5.6 so I think it is in fact fixed with 1.8.0 🎉 |
@realJoshByrnes Let me know how it fairs for you using 1.8 on a Mac. If it appears to be good to go for you, I'll close this. Otherwise I'll leave it open if you are having issues. |
how do I compile my script? |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
When trying to compile on 1.7 it gives an error about plugin not being initialized (importing webview for this program), however, when doing deno run in 1.7 or when compiling on 1.6, everything works as expected without any changes to the code.
The text was updated successfully, but these errors were encountered: